Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

(v8.x backport) readline,test: update references to archived repository #19119

Closed
wants to merge 2 commits into from
Closed
Changes from 1 commit
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Next Next commit
test: update references to archived repository
PR-URL: #17924
Reviewed-By: Anna Henningsen <[email protected]>
Reviewed-By: Colin Ihrig <[email protected]>
Reviewed-By: Jon Moss <[email protected]>
Reviewed-By: Luigi Pinca <[email protected]>
Reviewed-By: James M Snell <[email protected]>
Reviewed-By: Ruben Bridgewater <[email protected]>
tniessen committed Mar 4, 2018

Verified

This commit was signed with the committer’s verified signature.
tniessen Tobias Nießen
commit 790553c39527979bd80a7bdc5b2b0eabf27e2637
4 changes: 2 additions & 2 deletions test/parallel/test-assert.js
Original file line number Diff line number Diff line change
@@ -586,7 +586,7 @@ testAssertionMessage({ a: undefined, b: null }, '{ a: undefined, b: null }');
testAssertionMessage({ a: NaN, b: Infinity, c: -Infinity },
'{ a: NaN, b: Infinity, c: -Infinity }');

// #2893
// https://github.com/nodejs/node-v0.x-archive/issues/2893
{
let threw = false;
try {
@@ -601,7 +601,7 @@ testAssertionMessage({ a: NaN, b: Infinity, c: -Infinity },
assert.ok(threw);
}

// #5292
// https://github.com/nodejs/node-v0.x-archive/issues/5292
try {
assert.strictEqual(1, 2);
} catch (e) {
14 changes: 9 additions & 5 deletions test/parallel/test-buffer-alloc.js
Original file line number Diff line number Diff line change
@@ -636,7 +636,8 @@ assert.strictEqual('<Buffer 81 a3 66 6f 6f a3 62 61 72>', x.inspect());
}

{
// #1210 Test UTF-8 string includes null character
// https://github.com/nodejs/node-v0.x-archive/pull/1210
// Test UTF-8 string includes null character
let buf = Buffer.from('\0');
assert.strictEqual(buf.length, 1);
buf = Buffer.from('\0\0');
@@ -660,7 +661,8 @@ assert.strictEqual('<Buffer 81 a3 66 6f 6f a3 62 61 72>', x.inspect());
}

{
// #243 Test write() with maxLength
// https://github.com/nodejs/node-v0.x-archive/issues/243
// Test write() with maxLength
const buf = Buffer.allocUnsafe(4);
buf.fill(0xFF);
assert.strictEqual(buf.write('abcd', 1, 2, 'utf8'), 2);
@@ -886,12 +888,14 @@ assert.throws(() => Buffer.allocUnsafe(8).writeFloatLE(0.0, -1), RangeError);
assert.strictEqual(buf.readIntBE(0, 5), -0x0012000000);
}

// Regression test for #5482: should throw but not assert in C++ land.
// Regression test for https://github.com/nodejs/node-v0.x-archive/issues/5482:
// should throw but not assert in C++ land.
assert.throws(() => Buffer.from('', 'buffer'),
/^TypeError: "encoding" must be a valid string encoding$/);

// Regression test for #6111. Constructing a buffer from another buffer
// should a) work, and b) not corrupt the source buffer.
// Regression test for https://github.com/nodejs/node-v0.x-archive/issues/6111.
// Constructing a buffer from another buffer should a) work, and b) not corrupt
// the source buffer.
{
const a = [...Array(128).keys()]; // [0, 1, 2, 3, ... 126, 127]
const b = Buffer.from(a);
2 changes: 1 addition & 1 deletion test/parallel/test-cluster-worker-init.js
Original file line number Diff line number Diff line change
@@ -42,7 +42,7 @@ if (cluster.isMaster) {
worker.send(msg);
});
} else {
// GH #7998
// https://github.com/nodejs/node-v0.x-archive/issues/7998
cluster.worker.on('message', (message) => {
process.send(message === msg);
});
3 changes: 2 additions & 1 deletion test/parallel/test-crypto-binary-default.js
Original file line number Diff line number Diff line change
@@ -411,7 +411,8 @@ fileStream.on('close', common.mustCall(function() {
);
}));

// Issue #2227: unknown digest method should throw an error.
// Unknown digest method should throw an error:
// https://github.com/nodejs/node-v0.x-archive/issues/2227
assert.throws(function() {
crypto.createHash('xyzzy');
}, /^Error: Digest method not supported$/);
11 changes: 7 additions & 4 deletions test/parallel/test-crypto-cipher-decipher.js
Original file line number Diff line number Diff line change
@@ -70,15 +70,16 @@ testCipher1(Buffer.from('MySecretKey123'));
testCipher2('0123456789abcdef');
testCipher2(Buffer.from('0123456789abcdef'));

// Base64 padding regression test, see #4837.
// Base64 padding regression test, see
// https://github.com/nodejs/node-v0.x-archive/issues/4837.
{
const c = crypto.createCipher('aes-256-cbc', 'secret');
const s = c.update('test', 'utf8', 'base64') + c.final('base64');
assert.strictEqual(s, '375oxUQCIocvxmC5At+rvA==');
}

// Calling Cipher.final() or Decipher.final() twice should error but
// not assert. See #4886.
// not assert. See https://github.com/nodejs/node-v0.x-archive/issues/4886.
{
const c = crypto.createCipher('aes-256-cbc', 'secret');
try { c.final('xxx'); } catch (e) { /* Ignore. */ }
@@ -90,14 +91,16 @@ testCipher2(Buffer.from('0123456789abcdef'));
try { d.final('xxx'); } catch (e) { /* Ignore. */ }
}

// Regression test for #5482: string to Cipher#update() should not assert.
// Regression test for https://github.com/nodejs/node-v0.x-archive/issues/5482:
// string to Cipher#update() should not assert.
{
const c = crypto.createCipher('aes192', '0123456789abcdef');
c.update('update');
c.final();
}

// #5655 regression tests, 'utf-8' and 'utf8' are identical.
// https://github.com/nodejs/node-v0.x-archive/issues/5655 regression tests,
// 'utf-8' and 'utf8' are identical.
{
let c = crypto.createCipher('aes192', '0123456789abcdef');
c.update('update', ''); // Defaults to "utf8".
3 changes: 2 additions & 1 deletion test/parallel/test-crypto-hash.js
Original file line number Diff line number Diff line change
@@ -105,7 +105,8 @@ fileStream.on('close', common.mustCall(function() {
'Test SHA1 of sample.png');
}));

// Issue #2227: unknown digest method should throw an error.
// Issue https://github.com/nodejs/node-v0.x-archive/issues/2227: unknown digest
// method should throw an error.
assert.throws(function() {
crypto.createHash('xyzzy');
}, /Digest method not supported/);
5 changes: 3 additions & 2 deletions test/parallel/test-crypto-random.js
Original file line number Diff line number Diff line change
@@ -260,8 +260,9 @@ const expectedErrorRegexp = /^TypeError: size must be a number >= 0$/;
}
}

// #5126, "FATAL ERROR: v8::Object::SetIndexedPropertiesToExternalArrayData()
// length exceeds max acceptable value"
// https://github.com/nodejs/node-v0.x-archive/issues/5126,
// "FATAL ERROR: v8::Object::SetIndexedPropertiesToExternalArrayData() length
// exceeds max acceptable value"
assert.throws(function() {
crypto.randomBytes((-1 >>> 0) + 1);
}, /^TypeError: size must be a number >= 0$/);
4 changes: 2 additions & 2 deletions test/parallel/test-crypto.js
Original file line number Diff line number Diff line change
@@ -159,8 +159,8 @@ testImmutability(tls.getCiphers);
testImmutability(crypto.getHashes);
testImmutability(crypto.getCurves);

// Regression tests for #5725: hex input that's not a power of two should
// throw, not assert in C++ land.
// Regression tests for https://github.com/nodejs/node-v0.x-archive/pull/5725:
// hex input that's not a power of two should throw, not assert in C++ land.
assert.throws(function() {
crypto.createCipher('aes192', 'test').update('0', 'hex');
}, (err) => {
2 changes: 1 addition & 1 deletion test/parallel/test-dgram-ref.js
Original file line number Diff line number Diff line change
@@ -23,7 +23,7 @@
const common = require('../common');
const dgram = require('dgram');

// should not hang, see #1282
// should not hang, see https://github.com/nodejs/node-v0.x-archive/issues/1282
dgram.createSocket('udp4');
dgram.createSocket('udp6');

3 changes: 2 additions & 1 deletion test/parallel/test-dns-regress-7070.js
Original file line number Diff line number Diff line change
@@ -24,7 +24,8 @@ require('../common');
const assert = require('assert');
const dns = require('dns');

// Should not raise assertion error. Issue #7070
// Should not raise assertion error.
// Issue https://github.com/nodejs/node-v0.x-archive/issues/7070
assert.throws(() => dns.resolveNs([]), // bad name
/^Error: "name" argument must be a string$/);
assert.throws(() => dns.resolveNs(''), // bad callback
3 changes: 2 additions & 1 deletion test/parallel/test-timers-unref.js
Original file line number Diff line number Diff line change
@@ -71,7 +71,8 @@ const check_unref = setInterval(() => {
setInterval(() => timeout.unref(), SHORT_TIME);
}

// Should not assert on args.Holder()->InternalFieldCount() > 0. See #4261.
// Should not assert on args.Holder()->InternalFieldCount() > 0.
// See https://github.com/nodejs/node-v0.x-archive/issues/4261.
{
const t = setInterval(() => {}, 1);
process.nextTick(t.unref.bind({}));
2 changes: 1 addition & 1 deletion test/parallel/test-tls-set-encoding.js
Original file line number Diff line number Diff line change
@@ -63,7 +63,7 @@ server.listen(0, function() {
client.on('close', function() {
// readyState is deprecated but we want to make
// sure this isn't triggering an assert in lib/net.js
// See issue #1069.
// See https://github.com/nodejs/node-v0.x-archive/issues/1069.
assert.strictEqual('closed', client.readyState);

// Confirming the buffer string is encoded in ASCII
6 changes: 4 additions & 2 deletions test/sequential/test-child-process-execsync.js
Original file line number Diff line number Diff line change
@@ -93,7 +93,8 @@ ret = execFileSync(process.execPath, args, { encoding: 'utf8' });

assert.strictEqual(ret, `${msg}\n`);

// Verify that the cwd option works - GH #7824
// Verify that the cwd option works.
// See https://github.com/nodejs/node-v0.x-archive/issues/7824.
{
const cwd = common.rootDir;
const cmd = common.isWindows ? 'echo %cd%' : 'pwd';
@@ -102,7 +103,8 @@ assert.strictEqual(ret, `${msg}\n`);
assert.strictEqual(response.toString().trim(), cwd);
}

// Verify that stderr is not accessed when stdio = 'ignore' - GH #7966
// Verify that stderr is not accessed when stdio = 'ignore'.
// See https://github.com/nodejs/node-v0.x-archive/issues/7966.
{
assert.throws(function() {
execSync('exit -1', { stdio: 'ignore' });
6 changes: 4 additions & 2 deletions test/sequential/test-module-loading.js
Original file line number Diff line number Diff line change
@@ -222,7 +222,8 @@ try {
}

{
// #1357 Loading JSON files with require()
// Loading JSON files with require()
// See https://github.com/nodejs/node-v0.x-archive/issues/1357.
const json = require('../fixtures/packages/main/package.json');
assert.deepStrictEqual(json, {
name: 'package-name',
@@ -337,7 +338,8 @@ process.on('exit', function() {
});


// #1440 Loading files with a byte order marker.
// Loading files with a byte order marker.
// See https://github.com/nodejs/node-v0.x-archive/issues/1440.
assert.strictEqual(require('../fixtures/utf8-bom.js'), 42);
assert.strictEqual(require('../fixtures/utf8-bom.json'), 42);