Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

dns: add dns trace events #19157

Closed
wants to merge 1 commit into from
Closed

dns: add dns trace events #19157

wants to merge 1 commit into from

Conversation

jasnell
Copy link
Member

@jasnell jasnell commented Mar 6, 2018 •
edited
Loading

Add the node.dns trace event category.
Emit trace events for dns operations.

Note: this still needs a test

Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • tests and/or benchmarks are included
  • documentation is changed or added
  • commit message follows commit guidelines

@jasnell jasnell added dns Issues and PRs related to the dns subsystem. trace_events Issues and PRs related to V8, Node.js core, and userspace code trace events. labels Mar 6, 2018
@nodejs-github-bot nodejs-github-bot added c++ Issues and PRs that require attention from people who are familiar with C++. cares Issues and PRs related to the c-ares dependency or the cares_wrap binding. labels Mar 6, 2018
@jasnell jasnell added the wip Issues and PRs that are still a work in progress. label Mar 6, 2018
@BridgeAR
Copy link
Member

BridgeAR commented Apr 9, 2018

Ping @jasnell

@jasnell
Copy link
Member Author

jasnell commented Apr 9, 2018

Haven't forgotten. Please leave this open

@BridgeAR
Copy link
Member

Ping @jasnell

@jasnell
Copy link
Member Author

jasnell commented Apr 28, 2018

Yep. Please leave this open. Still a work in progress.

@chinhuang007 chinhuang007 mentioned this pull request Jul 16, 2018
Closed
1 task
@chinhuang007
Copy link
Contributor

@jasnell I created a new PR, took your code, modified it to use nestable async events, and added test code. Please help review. And at the end maybe close this one.

@jasnell
Copy link
Member Author

jasnell commented Jul 16, 2018

Excellent. I'll take a look in the next day or two

@jasnell
Copy link
Member Author

jasnell commented Jul 20, 2018

Closing this in favor of the new PR :-)

@jasnell jasnell closed this Jul 20, 2018
chinhuang007 added a commit to chinhuang007/node that referenced this pull request Aug 20, 2018
@chinhuang007
src: add trace points to dns
7ceedb9 
Add trace points to dns under node.dns.native category.
Emit trace events for dns operations. Use the
nestable async events instead of deprecated ones.
Include test code to verify the trace log. The
trace name is stored as const char* class variable.
The test code is to check each operation in separate
sync processes.

Refs: nodejs#19157
addaleax pushed a commit that referenced this pull request Sep 2, 2018
@chinhuang007 @addaleax
src: add trace points to dns
b366de5 
Add trace points to dns under node.dns.native category.
Emit trace events for dns operations. Use the
nestable async events instead of deprecated ones.
Include test code to verify the trace log. The
trace name is stored as const char* class variable.
The test code is to check each operation in separate
sync processes.

Refs: #19157

PR-URL: #21840
Reviewed-By: Anna Henningsen <[email protected]>
Reviewed-By: James M Snell <[email protected]>
Reviewed-By: Gireesh Punathil <[email protected]>
Reviewed-By: Colin Ihrig <[email protected]>
Reviewed-By: Joyee Cheung <[email protected]>
targos pushed a commit that referenced this pull request Sep 3, 2018
@chinhuang007 @targos
src: add trace points to dns
c8e586c 
Add trace points to dns under node.dns.native category.
Emit trace events for dns operations. Use the
nestable async events instead of deprecated ones.
Include test code to verify the trace log. The
trace name is stored as const char* class variable.
The test code is to check each operation in separate
sync processes.

Refs: #19157

PR-URL: #21840
Reviewed-By: Anna Henningsen <[email protected]>
Reviewed-By: James M Snell <[email protected]>
Reviewed-By: Gireesh Punathil <[email protected]>
Reviewed-By: Colin Ihrig <[email protected]>
Reviewed-By: Joyee Cheung <[email protected]>
targos pushed a commit that referenced this pull request Sep 6, 2018
@chinhuang007 @targos
src: add trace points to dns
c52d67b 
Add trace points to dns under node.dns.native category.
Emit trace events for dns operations. Use the
nestable async events instead of deprecated ones.
Include test code to verify the trace log. The
trace name is stored as const char* class variable.
The test code is to check each operation in separate
sync processes.

Refs: #19157

PR-URL: #21840
Reviewed-By: Anna Henningsen <[email protected]>
Reviewed-By: James M Snell <[email protected]>
Reviewed-By: Gireesh Punathil <[email protected]>
Reviewed-By: Colin Ihrig <[email protected]>
Reviewed-By: Joyee Cheung <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
c++ Issues and PRs that require attention from people who are familiar with C++. cares Issues and PRs related to the c-ares dependency or the cares_wrap binding. dns Issues and PRs related to the dns subsystem. trace_events Issues and PRs related to V8, Node.js core, and userspace code trace events. wip Issues and PRs that are still a work in progress.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@jasnell @BridgeAR @chinhuang007 @nodejs-github-bot