Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

stream: fix error handling with async iteration #20329

Closed
wants to merge 4 commits into from
Closed

stream: fix error handling with async iteration #20329

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
0b529b2
stream: fix error handling with async iteration
julien-f Apr 26, 2018
0e5995a
coding style
julien-f Apr 26, 2018
fea77e0
test by error identity
julien-f Apr 26, 2018
c8c410a
add missing semi
julien-f Apr 26, 2018
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion lib/internal/streams/async_iterator.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -58,7 +58,7 @@ function onError(iter, err) {
iter[kLastReject] = null;
reject(err);
}
iter.error = err;
iter[kError] = err;
}

function wrapForNext(lastPromise, iter) {
Expand Down
17 changes: 17 additions & 0 deletions test/parallel/test-stream-readable-async-iterators.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -115,6 +115,23 @@ async function tests() {
readable.destroy(new Error('kaboom'));
})();

await (async function() {
console.log('call next() after error');
const readable = new Readable({
read() {}
})
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nit, missing semicolon


let err
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nit, missing semicolon. Please run make lint :)

try {
const iterator = readable[Symbol.asyncIterator]();
readable.destroy(new Error('kaboom'));
await iterator.next();
} catch (e) {
err = e;
}
assert.strictEqual(err.message, 'kaboom');
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can we assert that we have reference equality and assert Node doesn't mutate the error (basically define the error above and assert that strictEqual on the instance?

Also - you can use the newly added assert.rejects (although no obligation)

})();

await (async function() {
console.log('read object mode');
const max = 42;
Expand Down