Add tests for platform specific error codes for fs.rmdir on file #22095
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
i've not tested this on windows (dont have a win machine), so could use some help with that :) |
|
CI (including Windows) : https://ci.nodejs.org/job/node-test-pull-request/16179/ |
…into test-rmdir-file * 'test-rmdir-file' of https://github.com/gautamarora/node: test: use only error codes test: error code on win vs posix for rmdir on file
|
@gautamarora Looks like some extra commits got pulled in here -- can you rebase on master and see if that fixes the issue? |
|
@gautamarora ping, could you rebase this on master, please? |
Trott
reviewed
Nov 16, 2018
| assert.throws(function() { | ||
| fs.rmdirSync(f); | ||
| }, /ENOTDIR/); | ||
| } |
There was a problem hiding this comment.
Maybe this?:
assert.throws(() => { fs.rmdirSync(f); }
common.isWindows ? /ENOENT/ : /ENOTDIR/);
|
Closing due to a long inactivity. @gautamarora thanks a lot for your contribution nevertheless. It is much appreciated. If you would like to continue working on this, please just open a new PR or leave a comment here. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As per the discussion at #8797 and subsequent fix to documentation here,
fs.rmdirhas different error codes on windows vs posix systems.This PR adds a test case to account for this difference in error codes.
This PR also updates the existing test to wrap each "case" with an anonymous scope.
Checklist
make -j4 test(UNIX), orvcbuild test(Windows) passes