Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

FAST HTTP YEAH #2355

Closed
wants to merge 4 commits into from
+306 −63
Closed

FAST HTTP YEAH #2355

Changes from 1 commit
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
59b91f1
http_parser: consume StreamBase instance
indutny Aug 12, 2015
bc82108
improvement
indutny Aug 26, 2015
d94f7f4
env: introduce `KickNextTick`
indutny Aug 26, 2015
5cb0a0e
http_parser: follow-up fixes
indutny Aug 26, 2015
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
http_parser: follow-up fixes
@indutny
indutny committed Aug 26, 2015
commit 5cb0a0ec7da0cd546c288327b70c5164b7bcbd88
7 changes: 0 additions & 7 deletions lib/_http_server.js
View file
Original file line number Diff line number Diff line change
@@ -255,10 +255,6 @@ Server.prototype.setTimeout = function(msecs, callback) {
exports.Server = Server;


function noop() {
}


function connectionListener(socket) {
var self = this;
var outgoing = [];
@@ -354,9 +350,6 @@ function connectionListener(socket) {
function onParserExecute(ret, d) {
debug('SERVER socketOnParserExecute %d', ret);
onParserExecuteCommon(ret, undefined);

// Kick-off next ticks
setImmediate(noop);
}

function onParserExecuteCommon(ret, d) {
2 changes: 2 additions & 0 deletions src/node_http_parser.cc
View file
Original file line number Diff line number Diff line change
@@ -562,6 +562,8 @@ class Parser : public BaseObject {

parser->current_buffer_len_ = 0;
parser->current_buffer_data_ = nullptr;

parser->env()->KickNextTick();
}