Skip to content

tools: update ESLint to 5.7.0 #23629

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Oct 15, 2018
Merged

tools: update ESLint to 5.7.0 #23629

merged 1 commit into from
Oct 15, 2018

Conversation

cjihrig
Copy link
Contributor

@cjihrig cjihrig commented Oct 12, 2018

Update ESLint to 5.7.0.

Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • commit message follows commit guidelines

Sorry, something went wrong.

@nodejs-github-bot nodejs-github-bot added the tools Issues and PRs related to the tools directory. label Oct 12, 2018
Copy link
Member

@Trott Trott left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Rubber-stamp LGTM

Copy link
Member

@trivikr trivikr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

RSLGTM

Copy link
Contributor

@thefourtheye thefourtheye left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM if the build is happy.

Verified

This commit was signed with the committer’s verified signature.
cjihrig Colin Ihrig
Update ESLint to 5.7.0.

PR-URL: nodejs#23629
Reviewed-By: Rich Trott <[email protected]>
Reviewed-By: Trivikram Kamat <[email protected]>
Reviewed-By: Sakthipriyan Vairamani <[email protected]>
@cjihrig
Copy link
Contributor Author

cjihrig commented Oct 15, 2018

@cjihrig cjihrig merged commit ea9df8b into nodejs:master Oct 15, 2018
@cjihrig cjihrig deleted the eslint branch October 15, 2018 00:13
jasnell pushed a commit that referenced this pull request Oct 17, 2018

Verified

This commit was signed with the committer’s verified signature.
jasnell James M Snell
Update ESLint to 5.7.0.

PR-URL: #23629
Reviewed-By: Rich Trott <[email protected]>
Reviewed-By: Trivikram Kamat <[email protected]>
Reviewed-By: Sakthipriyan Vairamani <[email protected]>
addaleax pushed a commit that referenced this pull request Oct 20, 2018

Verified

This commit was signed with the committer’s verified signature. The key has expired.
addaleax Anna Henningsen
Update ESLint to 5.7.0.

PR-URL: #23629
Reviewed-By: Rich Trott <[email protected]>
Reviewed-By: Trivikram Kamat <[email protected]>
Reviewed-By: Sakthipriyan Vairamani <[email protected]>
MylesBorins pushed a commit that referenced this pull request Oct 30, 2018

Unverified

The email in this signature doesn’t match the committer email.
Update ESLint to 5.7.0.

PR-URL: #23629
Reviewed-By: Rich Trott <[email protected]>
Reviewed-By: Trivikram Kamat <[email protected]>
Reviewed-By: Sakthipriyan Vairamani <[email protected]>
@codebytere codebytere mentioned this pull request Nov 27, 2018
rvagg pushed a commit that referenced this pull request Nov 28, 2018
Update ESLint to 5.7.0.

PR-URL: #23629
Reviewed-By: Rich Trott <[email protected]>
Reviewed-By: Trivikram Kamat <[email protected]>
Reviewed-By: Sakthipriyan Vairamani <[email protected]>
MylesBorins pushed a commit that referenced this pull request Nov 29, 2018

Unverified

The email in this signature doesn’t match the committer email.
Update ESLint to 5.7.0.

PR-URL: #23629
Reviewed-By: Rich Trott <[email protected]>
Reviewed-By: Trivikram Kamat <[email protected]>
Reviewed-By: Sakthipriyan Vairamani <[email protected]>
@codebytere codebytere mentioned this pull request Nov 29, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
tools Issues and PRs related to the tools directory.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants