Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix various memory leaks #2375

Closed
wants to merge 6 commits into from
+26 −4
Closed

Fix various memory leaks #2375

Changes from 1 commit
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
b1a5d1e
src: fix memory leak in DLOpen
skomski Aug 14, 2015
cc8ac7a
crypto: fix memory leak in SetDHParam
skomski Aug 14, 2015
ca3f4eb
crypto: fix memory leak in SafeX509ExtPrint
skomski Aug 14, 2015
1a35744
crypto: fix memory leak in PublicKeyCipher::Cipher
skomski Aug 14, 2015
e41eb9d
crypto: fix memory leak in ECDH::SetPrivateKey
skomski Aug 14, 2015
5c2e1eb
crypto: fix memory leak in PBKDF2Request
skomski Aug 14, 2015
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
crypto: fix memory leak in SetDHParam
@skomski
skomski committed Aug 14, 2015
commit cc8ac7a762ec246a6c60c984dd6ef92bfd84a506
6 changes: 4 additions & 2 deletions src/node_crypto.cc
View file
Original file line number Diff line number Diff line change
@@ -805,10 +805,12 @@ void SecureContext::SetDHParam(const FunctionCallbackInfo<Value>& args) {
return;

const int keylen = BN_num_bits(dh->p);
if (keylen < 1024)
if (keylen < 1024) {
DH_free(dh);
return env->ThrowError("DH parameter is less than 1024 bits");
else if (keylen < 2048)
} else if (keylen < 2048) {
fprintf(stderr, "WARNING: DH parameter is less than 2048 bits\n");
}

SSL_CTX_set_options(sc->ctx_, SSL_OP_SINGLE_DH_USE);
int r = SSL_CTX_set_tmp_dh(sc->ctx_, dh);