Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

http2: add test for ERR_HTTP2_ORIGIN_LENGTH #24014

Closed
wants to merge 1 commit into from
Closed

http2: add test for ERR_HTTP2_ORIGIN_LENGTH #24014

wants to merge 1 commit into from

Conversation

trivikr
Copy link
Member

@trivikr trivikr commented Nov 1, 2018

Adds test for ERR_HTTP2_ORIGIN_LENGTH
It's not covered in the latest coverage

Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • tests and/or benchmarks are included
  • commit message follows commit guidelines

@nodejs-github-bot
Copy link
Collaborator

@trivikr build started: https://ci.nodejs.org/blue/organizations/jenkins/node-test-pull-request-lite-pipeline/detail/node-test-pull-request-lite-pipeline/1448/pipeline

@nodejs-github-bot nodejs-github-bot added the test Issues and PRs related to the tests. label Nov 1, 2018
@trivikr trivikr self-assigned this Nov 1, 2018
@trivikr trivikr added the http2 Issues or PRs related to the http2 subsystem. label Nov 1, 2018
@trivikr
Copy link
Member Author

trivikr commented Nov 1, 2018

CI: https://ci.nodejs.org/job/node-test-pull-request/18279/

@trivikr trivikr added the author ready PRs that have at least one approval, no pending requests for changes, and a CI started. label Nov 1, 2018
@trivikr
Copy link
Member Author

trivikr commented Nov 3, 2018

Closing reason: This is a backup PR for my talk about writing unit tests at NodeConfEU
If time permits, I plan to post this code change live (in another PR) at around 11:20 UTC on Tuesday November 5th, 2018. If you're free at that time, do review it live and post some comments 😊

@trivikr trivikr closed this Nov 3, 2018
@trivikr trivikr deleted the test-origin-length branch August 31, 2023 14:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jasnell jasnell jasnell approved these changes

@addaleax addaleax addaleax approved these changes

@lpinca lpinca lpinca approved these changes

@cjihrig cjihrig cjihrig approved these changes

Assignees

@trivikr trivikr

Labels
author ready PRs that have at least one approval, no pending requests for changes, and a CI started. http2 Issues or PRs related to the http2 subsystem. test Issues and PRs related to the tests.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@trivikr @nodejs-github-bot @jasnell @addaleax @lpinca @cjihrig