-
Notifications
You must be signed in to change notification settings - Fork 31k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
net: allow reading data into a static buffer #25436
Merged
+474
−65
Merged
Changes from all commits
Commits
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,186 @@ | ||
| 'use strict'; | ||
| const common = require('../common'); | ||
| const assert = require('assert'); | ||
| const net = require('net'); | ||
|
|
||
| const message = Buffer.from('hello world'); | ||
|
|
||
| // Test typical usage | ||
| net.createServer(common.mustCall(function(socket) { | ||
| this.close(); | ||
| socket.end(message); | ||
| })).listen(0, function() { | ||
| let received = 0; | ||
| const buffers = []; | ||
| const sockBuf = Buffer.alloc(8); | ||
| net.connect({ | ||
| port: this.address().port, | ||
| onread: { | ||
| buffer: sockBuf, | ||
| callback: function(nread, buf) { | ||
| assert.strictEqual(buf, sockBuf); | ||
| received += nread; | ||
| buffers.push(Buffer.from(buf.slice(0, nread))); | ||
| } | ||
| } | ||
| }).on('data', common.mustNotCall()).on('end', common.mustCall(() => { | ||
| assert.strictEqual(received, message.length); | ||
| assert.deepStrictEqual(Buffer.concat(buffers), message); | ||
| })); | ||
| }); | ||
|
|
||
| // Test Uint8Array support | ||
| net.createServer(common.mustCall(function(socket) { | ||
| this.close(); | ||
| socket.end(message); | ||
| })).listen(0, function() { | ||
| let received = 0; | ||
| let incoming = new Uint8Array(0); | ||
| const sockBuf = new Uint8Array(8); | ||
| net.connect({ | ||
| port: this.address().port, | ||
| onread: { | ||
| buffer: sockBuf, | ||
| callback: function(nread, buf) { | ||
| assert.strictEqual(buf, sockBuf); | ||
| received += nread; | ||
| const newIncoming = new Uint8Array(incoming.length + nread); | ||
| newIncoming.set(incoming); | ||
| newIncoming.set(buf.slice(0, nread), incoming.length); | ||
| incoming = newIncoming; | ||
| } | ||
| } | ||
| }).on('data', common.mustNotCall()).on('end', common.mustCall(() => { | ||
| assert.strictEqual(received, message.length); | ||
| assert.deepStrictEqual(incoming, new Uint8Array(message)); | ||
| })); | ||
| }); | ||
|
|
||
| // Test Buffer callback usage | ||
| net.createServer(common.mustCall(function(socket) { | ||
| this.close(); | ||
| socket.end(message); | ||
| })).listen(0, function() { | ||
| let received = 0; | ||
| const incoming = []; | ||
| const bufPool = [ Buffer.alloc(2), Buffer.alloc(2), Buffer.alloc(2) ]; | ||
| let bufPoolIdx = -1; | ||
| let bufPoolUsage = 0; | ||
| net.connect({ | ||
| port: this.address().port, | ||
| onread: { | ||
| buffer: () => { | ||
| ++bufPoolUsage; | ||
| bufPoolIdx = (bufPoolIdx + 1) % bufPool.length; | ||
| return bufPool[bufPoolIdx]; | ||
| }, | ||
| callback: function(nread, buf) { | ||
| assert.strictEqual(buf, bufPool[bufPoolIdx]); | ||
| received += nread; | ||
| incoming.push(Buffer.from(buf.slice(0, nread))); | ||
| } | ||
| } | ||
| }).on('data', common.mustNotCall()).on('end', common.mustCall(() => { | ||
| assert.strictEqual(received, message.length); | ||
| assert.deepStrictEqual(Buffer.concat(incoming), message); | ||
| assert.strictEqual(bufPoolUsage, 7); | ||
| })); | ||
| }); | ||
|
|
||
| // Test Uint8Array callback support | ||
| net.createServer(common.mustCall(function(socket) { | ||
| this.close(); | ||
| socket.end(message); | ||
| })).listen(0, function() { | ||
| let received = 0; | ||
| let incoming = new Uint8Array(0); | ||
| const bufPool = [ new Uint8Array(2), new Uint8Array(2), new Uint8Array(2) ]; | ||
| let bufPoolIdx = -1; | ||
| let bufPoolUsage = 0; | ||
| net.connect({ | ||
| port: this.address().port, | ||
| onread: { | ||
| buffer: () => { | ||
| ++bufPoolUsage; | ||
| bufPoolIdx = (bufPoolIdx + 1) % bufPool.length; | ||
| return bufPool[bufPoolIdx]; | ||
| }, | ||
| callback: function(nread, buf) { | ||
| assert.strictEqual(buf, bufPool[bufPoolIdx]); | ||
| received += nread; | ||
| const newIncoming = new Uint8Array(incoming.length + nread); | ||
| newIncoming.set(incoming); | ||
| newIncoming.set(buf.slice(0, nread), incoming.length); | ||
| incoming = newIncoming; | ||
| } | ||
| } | ||
| }).on('data', common.mustNotCall()).on('end', common.mustCall(() => { | ||
| assert.strictEqual(received, message.length); | ||
| assert.deepStrictEqual(incoming, new Uint8Array(message)); | ||
| assert.strictEqual(bufPoolUsage, 7); | ||
| })); | ||
| }); | ||
|
|
||
| // Test explicit socket pause | ||
| net.createServer(common.mustCall(function(socket) { | ||
| this.close(); | ||
| socket.end(message); | ||
| })).listen(0, function() { | ||
| let received = 0; | ||
| const buffers = []; | ||
| const sockBuf = Buffer.alloc(8); | ||
| let paused = false; | ||
| net.connect({ | ||
| port: this.address().port, | ||
| onread: { | ||
| buffer: sockBuf, | ||
| callback: function(nread, buf) { | ||
| assert.strictEqual(paused, false); | ||
| assert.strictEqual(buf, sockBuf); | ||
| received += nread; | ||
| buffers.push(Buffer.from(buf.slice(0, nread))); | ||
| paused = true; | ||
| this.pause(); | ||
| setTimeout(() => { | ||
| paused = false; | ||
| this.resume(); | ||
| }, 100); | ||
| } | ||
| } | ||
| }).on('data', common.mustNotCall()).on('end', common.mustCall(() => { | ||
| assert.strictEqual(received, message.length); | ||
| assert.deepStrictEqual(Buffer.concat(buffers), message); | ||
| })); | ||
| }); | ||
|
|
||
| // Test implicit socket pause | ||
| net.createServer(common.mustCall(function(socket) { | ||
| this.close(); | ||
| socket.end(message); | ||
| })).listen(0, function() { | ||
| let received = 0; | ||
| const buffers = []; | ||
| const sockBuf = Buffer.alloc(8); | ||
| let paused = false; | ||
| net.connect({ | ||
| port: this.address().port, | ||
| onread: { | ||
| buffer: sockBuf, | ||
| callback: function(nread, buf) { | ||
| assert.strictEqual(paused, false); | ||
| assert.strictEqual(buf, sockBuf); | ||
| received += nread; | ||
| buffers.push(Buffer.from(buf.slice(0, nread))); | ||
| paused = true; | ||
| setTimeout(() => { | ||
| paused = false; | ||
| this.resume(); | ||
| }, 100); | ||
| return false; | ||
| } | ||
| } | ||
| }).on('data', common.mustNotCall()).on('end', common.mustCall(() => { | ||
| assert.strictEqual(received, message.length); | ||
| assert.deepStrictEqual(Buffer.concat(buffers), message); | ||
| })); | ||
| }); |
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
An example showing this in use would be ideal.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Added. Let me know if it suffices.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you! looks good