Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

process: expose process.features.inspector #25819

Closed
wants to merge 4 commits into from
+25 −28
Closed

process: expose process.features.inspector #25819

Changes from 1 commit
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
731f799
process: expose process.features.inspector
joyeecheung Jan 30, 2019
66aebeb
fixup! process: expose process.features.inspector
joyeecheung Jan 30, 2019
137426e
fixup! process: expose process.features.inspector
refack Jan 30, 2019
67e20d1
fixup! fixup! process: expose process.features.inspector
joyeecheung Jan 31, 2019
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
fixup! process: expose process.features.inspector 
Co-Authored-By: joyeecheung <[email protected]>
@refack @joyeecheung
refack and joyeecheung authored Jan 30, 2019

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature. The key has expired.
GPG key ID: 4AEE18F83AFDEB23
Expired
Verified
Learn about vigilant mode
commit 137426ed93dd372d7a76177f15b6fac8a047b89a
2 changes: 1 addition & 1 deletion tools/test.py
View file
Original file line number Diff line number Diff line change
@@ -1654,7 +1654,7 @@ def Main():
# We want to skip the inspector tests if node was built without the inspector.
has_inspector = Execute([vm,
'-p', 'process.features.inspector'], context)
if has_inspector.stdout.rstrip() == '0':
if has_inspector.stdout.rstrip() == 'false':
context.v8_enable_inspector = False

has_crypto = Execute([vm,