Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

assert: minor assert improvements #27525

Closed
wants to merge 4 commits into from
+83 −60
Closed

assert: minor assert improvements #27525

Changes from 1 commit
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
2f86e62
assert: fix `assert.fail()` stack
BridgeAR May 1, 2019
2236e8e
assert: refine assertion message
BridgeAR May 1, 2019
d993bb9
assert: use less read operations
BridgeAR May 1, 2019
1ae3571
fixup! assert: use less read operations
BridgeAR May 3, 2019
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 2 additions & 7 deletions lib/assert.js
View file
Original file line number Diff line number Diff line change
@@ -172,8 +172,8 @@ function getCode(fd, line, column) {
let lines = 0;
// Prevent blocking the event loop by limiting the maximum amount of
// data that may be read.
let maxReads = 64; // bytesPerRead * maxReads = 512 kb
const bytesPerRead = 8192;
let maxReads = 2 ** 5; // bytesPerRead * maxReads = 512 kb
const bytesPerRead = 2 ** 14;
// Use a single buffer up front that is reused until the call site is found.
let buffer = Buffer.allocUnsafe(bytesPerRead);
while (maxReads-- !== 0) {
@@ -619,11 +619,6 @@ function checkIsPromise(obj) {
// Accept native ES6 promises and promises that are implemented in a similar
// way. Do not accept thenables that use a function as `obj` and that have no
// `catch` handler.

// TODO: thenables are checked up until they have the correct methods,
// but according to documentation, the `then` method should receive
// the `fulfill` and `reject` arguments as well or it may be never resolved.

return isPromise(obj) ||
obj !== null && typeof obj === 'object' &&
typeof obj.then === 'function' &&