-
Notifications
You must be signed in to change notification settings - Fork 31.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
timer: call list.start regardless new or not #2788
Conversation
Call start regardless whether list is new or not to prevent incorrect active_handles count. Fixes nodejs/node-v0.x-archive#25831.
@@ -0,0 +1,36 @@ | |||
var cp = require('child_process'); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
use strict
should be the first line.
The |
Is it possible to create a test that doesn't have to compile C++ code (while tests are running)? Maybe utilize |
@mscdex, the c++ code is used to expose uv_run to js, not for reporting active handles. |
Why do you need uv_run to test incorrect active handles count? |
Please move the tests into |
Just realized pr should be applied to master branch. I will close this pr and submit a new one. @mscdex, in my updated test case of the new pr, I found @vkurchatkin , |
Call start regardless whether list is new
or not to prevent incorrect active_handles
count.
Fixes nodejs/node-v0.x-archive#25831.
Ported from pr nodejs/node-v0.x-archive#25832.