Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

async_hooks: buffer bootstrap events #29848

Closed
wants to merge 10 commits into from
+227 −28
Closed

async_hooks: buffer bootstrap events #29848

Changes from 1 commit
Commits
Show all changes
10 commits
Select commit Hold shift + click to select a range
b4aa8f6
async_hooks: buffer bootstrap events
guybedford Oct 4, 2019
c28ae36
fixup example api
guybedford Oct 4, 2019
1f9e145
keep runMain in cjs
guybedford Oct 5, 2019
3bff274
add enable comment
guybedford Oct 5, 2019
f058f9f
dont delay disable
guybedford Oct 5, 2019
f8416ce
flush microtask queue instead of making sync disable
guybedford Oct 5, 2019
ac7fdca
fixup doc links
guybedford Oct 5, 2019
ae46f45
stop bootstrap buffer as soon as usercode runs
guybedford Oct 6, 2019
96dd1b9
refine promise timings
guybedford Oct 6, 2019
d98d0f1
ensure fully sync detachment
guybedford Oct 7, 2019
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
fixup example api
@guybedford
guybedford committed Oct 6, 2019
commit c28ae364a4e3cfbc251f68591eedda93a9eca6ff
2 changes: 1 addition & 1 deletion doc/api/async_hooks.md
View file
Original file line number Diff line number Diff line change
@@ -323,7 +323,7 @@ elaborate to make calling context easier to see.
let indent = 0;
const bootstrapIds = new Set();
async_hooks.createHook({
init(asyncId, type, triggerAsyncId, bootstrap) {
init(asyncId, type, triggerAsyncId, resource, bootstrap) {
if (bootstrap) {
bootstrapIds.add(asyncId);
return;