Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

v13.1.0 release proposal #30262

Merged
merged 65 commits into from
Nov 5, 2019
Merged
Changes from 1 commit
Commits
Show all changes
65 commits
Select commit Hold shift + click to select a range
1d03df4
crypto: add Hash.prototype.copy() method
bnoordhuis Oct 9, 2019
a63f7e7
dgram: add source-specific multicast support
Oct 2, 2017
39070bb
doc: make YAML matter consistent in crypto.md
Trott Oct 18, 2019
5ca5864
cli: add --trace-uncaught flag
addaleax Oct 18, 2019
f01c5c5
inspector: turn platform tasks that outlive Agent into no-ops
addaleax Oct 18, 2019
5ba842b
build: python3 support for configure
rvagg Oct 21, 2019
8b75aab
crypto: guard with OPENSSL_NO_GOST
codebytere Oct 21, 2019
0d9ae1b
deps: V8: cherry-pick ed40ab1
targos Oct 22, 2019
edfbee3
module: resolve self-references
jkrems Aug 20, 2019
1cfa98c
deps: V8: cherry-pick c721203
targos Oct 22, 2019
a03809d
test: verify npm compatibility with releases
targos Oct 23, 2019
ea9d125
doc: add legendecas to collaborators
legendecas Oct 25, 2019
fd0aded
src: allow inspector without v8 platform
codebytere Oct 21, 2019
cedad02
build: prefer python 3 over 2 for configure
sam-github Oct 23, 2019
8980d8c
build: vcbuild uses default Python, not Py2
joaocgreis Oct 24, 2019
1d9f427
test: use arrow functions for callbacks
mpark86 Oct 22, 2019
93b1bb8
n-api,doc: add info about building n-api addons
jschlight Oct 18, 2019
4458378
async_hooks: only emit `after` for AsyncResource if stack not empty
addaleax Oct 23, 2019
45c70a9
doc: remove dashes
Trott Oct 24, 2019
381c6cd
doc: delete "a number of" things in the docs
Trott Oct 23, 2019
32a5389
doc,n-api: sort bottom-of-the-page references
Oct 25, 2019
9a71091
doc: revise os.md
Trott Oct 23, 2019
f3d00c5
deps: V8: backport 777fa98
targos Oct 22, 2019
d78e317
src: fix crash with SyntheticModule#setExport
targos Oct 22, 2019
621eaf9
doc: remove "it is important to" phrasing
Trott Oct 24, 2019
a375754
tools: doc: improve async workflow of generate.js
tpoisseau Oct 24, 2019
d91d270
doc: claim NODE_MODULE_VERSION=80 for Electron 9
MarshallOfSound Oct 21, 2019
3c23224
doc: adjust code sample for stream.finished
imcotton Oct 15, 2019
e4ab6fc
doc: remove incorrect and outdated example
tniessen Oct 26, 2019
07b5584
fs: add `bufferSize` option to `fs.opendir()`
addaleax Oct 25, 2019
d549a34
tools: update ESLint to 6.6.0
cjihrig Oct 25, 2019
d05f67c
cli: whitelist new V8 flag in NODE_OPTIONS
codebytere Oct 23, 2019
87f14e1
stream: extract Readable.from in its own file
mcollina Oct 26, 2019
98c8f76
src: split up InitializeContext
codebytere Oct 22, 2019
403a648
doc: fix numbering in require algorithm
jkrems Oct 25, 2019
978946e
doc,meta: prefer aliases and stubs over Runtime Deprecations
Trott Oct 28, 2019
2505f67
http: support readable hwm in IncomingMessage
cjihrig Oct 26, 2019
dfb4a24
doc: fix an error in resolution algorithm steps
Oct 11, 2019
a48d179
doc: add options description for send APIs
dev-script Oct 7, 2019
3709b5c
doc: move inactive Collaborators to emeriti
Trott Oct 30, 2019
e312448
deps: update npm to 6.12.1
Oct 29, 2019
1499a72
doc: improve doc Http2Session:Timeout
dev-script Oct 29, 2019
b255688
build: fix pkg-config search for libnghttp2
bnoordhuis Oct 27, 2019
ae81360
doc: update AUTHORS list
targos Oct 27, 2019
ec7b69f
src: change env.h includes for forward declarations
alferpal Oct 26, 2019
14981f5
tools: git rm -r tools/v8_gypfiles/broken
cclauss Oct 27, 2019
5469811
build: find Python syntax errors in dependencies
cclauss Oct 27, 2019
104bfb9
deps: V8: cherry-pick e5dbc95
Oct 30, 2019
bcbcce5
tools: undefined name opts -> args in gyptest.py
cclauss Oct 27, 2019
e2fb353
tools: use print() function in buildbot_run.py
cclauss Oct 27, 2019
348ec69
tools: fix Python 3 syntax error in mac_tool.py
cclauss Oct 27, 2019
f8fb2c0
doc: linkify `.fork()` in cluster documentation
addaleax Oct 29, 2019
050efeb
meta: use contact_links instead of issue templates
targos Oct 30, 2019
a0df91c
src: expose granular SetIsolateUpForNode
codebytere Oct 26, 2019
cc1cd2b
src: isolate->Dispose() order consistency
codebytere Oct 30, 2019
03827dd
build: allow Python 3.8
targos Oct 31, 2019
b7070f3
doc: explain http2 aborted event callback
dev-script Oct 30, 2019
201a60e
doc: linkify `.setupMaster()` in cluster doc
trivikr Nov 1, 2019
fc407bb
doc: add missing hash for header link
nschonni Oct 31, 2019
68e4b5a
tools: fix Python 3 deprecation warning in test.py
Hellzed Nov 1, 2019
46c9194
deps: V8: cherry-pick a7dffcd767be
cclauss Nov 3, 2019
8860bd6
buffer: improve performance caused by primordials
jizusun Nov 3, 2019
49e7f04
build: add workaround for WSL
gengjiawen Nov 2, 2019
1bded98
build: fix detection of Visual Studio 2017
richardlau Oct 25, 2019
64eacd8
2019-11-05, Version 13.1.0 (Current)
targos Nov 5, 2019
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
src: allow inspector without v8 platform
Embedders sometimes want to take control of V8 platform initialization
themselves, so we wouldn't want to experience an error if
NODE_USE_V8_PLATFORM was false necessarily. Instead, we can also gate
it with HAVE_INSPECTOR to allow embedders to define that themselves
and use Inspector without NODE_USE_V8_PLATFORM.

PR-URL: #30049
Reviewed-By: Anna Henningsen <[email protected]>
Reviewed-By: Minwoo Jung <[email protected]>
Reviewed-By: Joyee Cheung <[email protected]>
Reviewed-By: David Carlier <[email protected]>
Reviewed-By: Colin Ihrig <[email protected]>
Reviewed-By: Gireesh Punathil <[email protected]>
Reviewed-By: Anto Aravinth <[email protected]>
codebytere authored and targos committed Oct 28, 2019

Unverified

The email in this signature doesn’t match the committer email.
commit fd0aded233dc1ad743adc5ca80faa4807c470228
4 changes: 2 additions & 2 deletions src/node_options.cc
Original file line number Diff line number Diff line change
@@ -27,10 +27,10 @@ std::shared_ptr<PerProcessOptions> cli_options{new PerProcessOptions()};
} // namespace per_process

void DebugOptions::CheckOptions(std::vector<std::string>* errors) {
#if !NODE_USE_V8_PLATFORM
#if !NODE_USE_V8_PLATFORM && !HAVE_INSPECTOR
if (inspector_enabled) {
errors->push_back("Inspector is not available when Node is compiled "
"--without-v8-platform");
"--without-v8-platform and --without-inspector.");
}
#endif