Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

src: fix missing extra ca in secure contexts #32011

Closed
wants to merge 3 commits into from
Closed

src: fix missing extra ca in secure contexts #32011

wants to merge 3 commits into from

Conversation

ebickle
Copy link
Contributor

@ebickle ebickle commented Feb 28, 2020 •
edited
Loading

Fixes SecureContext missing NODE_EXTRA_CA_CERTS when
SecureContext::AddCACert, SecureContext::AddCRL,
or SecureContext::LoadPKCS12 are called.

Fixes: #32010

Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • tests and/or benchmarks are included
  • commit message follows commit guidelines

@ebickle
src: fix missing extra ca in secure contexts
d47a7ab 
Fixes SecureContext missing NODE_EXTRA_CA_CERTS when
SecureContext::AddCACert, SecureContext::AddCRL,
or SecureContext::LoadPKCS12 are called.

Fixes: nodejs#32010
@nodejs-github-bot nodejs-github-bot added c++ Issues and PRs that require attention from people who are familiar with C++. crypto Issues and PRs related to the crypto subsystem. labels Feb 28, 2020
@nodejs-github-bot
Copy link
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/29502/

BrandonE
BrandonE approved these changes Mar 4, 2020
View reviewed changes
@ebickle
src: perf improvement for CloneRootCertStore edge case
fc5d40e 
Bypass CloneRootCertStore() functionality when root_cert_store is null.
jasnell
jasnell reviewed Mar 5, 2020
View reviewed changes
@BridgeAR BridgeAR added the author ready PRs that have at least one approval, no pending requests for changes, and a CI started. label Mar 9, 2020
@nodejs-github-bot
Copy link
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/29674/

@nodejs-github-bot
Copy link
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/29745/

@addaleax addaleax removed the author ready PRs that have at least one approval, no pending requests for changes, and a CI started. label Mar 12, 2020
@addaleax
Copy link
Member

@ebickle Looks like there are some conflicts, sorry… could you rebase this?

@ebickle
Copy link
Contributor Author

ebickle commented Mar 17, 2020

This PR is affected by the same issue as #32229. Going to close it and resubmit a fix for #32229 and #32010 in a new PR.

@ebickle ebickle closed this Mar 17, 2020
@ebickle ebickle deleted the fix/tls-missing-extra-certs branch March 17, 2020 04:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sam-github sam-github sam-github approved these changes

@jasnell jasnell jasnell approved these changes

@BrandonE BrandonE BrandonE approved these changes

@devnexen devnexen devnexen approved these changes

Assignees
No one assigned
Labels
c++ Issues and PRs that require attention from people who are familiar with C++. crypto Issues and PRs related to the crypto subsystem.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Extra CA certificates missing when certain TLS options specified
8 participants
@ebickle @nodejs-github-bot @addaleax @sam-github @jasnell @BrandonE @devnexen @BridgeAR