Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[v16.x] deps: patch V8 to 9.4.146.24 #40616

Closed
wants to merge 1 commit into from
Closed

[v16.x] deps: patch V8 to 9.4.146.24 #40616

wants to merge 1 commit into from

Conversation

targos
Copy link
Member

@targos targos commented Oct 26, 2021

@targos targos changed the title deps: patch V8 to 9.4.146.23 [v16.x] deps: patch V8 to 9.4.146.23 Oct 26, 2021
@nodejs-github-bot nodejs-github-bot added needs-ci PRs that need a full CI run. v16.x v8 engine Issues and PRs related to the V8 dependency. labels Oct 26, 2021
@aduh95
Copy link
Contributor

aduh95 commented Oct 26, 2021

Shouldn't this be targeting v16.x-staging?

@targos targos changed the base branch from v16.x to v16.x-staging October 26, 2021 18:55
@nodejs-github-bot
Copy link
Collaborator

nodejs-github-bot commented Oct 27, 2021 •
edited by targos
Loading

CI: https://ci.nodejs.org/job/node-test-pull-request/40500/
V8: https://ci.nodejs.org/job/node-test-commit-v8-linux/4353/

This was referenced Oct 28, 2021
Open
Open
@targos targos changed the title [v16.x] deps: patch V8 to 9.4.146.23 [v16.x] deps: patch V8 to 9.4.146.24 Oct 29, 2021
@targos
Copy link
Member Author

targos commented Oct 29, 2021

Updated to 9.4.146.24

This was referenced Oct 30, 2021
Open
Open
@nodejs-github-bot
Copy link
Collaborator

nodejs-github-bot commented Oct 31, 2021 •
edited by targos
Loading

CI: https://ci.nodejs.org/job/node-test-pull-request/40598/
V8: https://ci.nodejs.org/job/node-test-commit-v8-linux/4361/

This was referenced Nov 1, 2021
Open
Open
Open
Open
@nodejs-github-bot
Copy link
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/40701/

@targos targos added the request-ci Add this label to start a Jenkins CI on a PR. label Nov 5, 2021
@github-actions github-actions bot removed the request-ci Add this label to start a Jenkins CI on a PR. label Nov 5, 2021
@nodejs-github-bot
Copy link
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/40725/

This was referenced Nov 6, 2021
Open
Open
@nodejs-github-bot
Copy link
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/40748/

@github-actions github-actions bot mentioned this pull request Nov 8, 2021
Open
46 tasks
@nodejs-github-bot
Copy link
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/40769/

@nodejs-github-bot
Copy link
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/40775/

@nodejs-github-bot
Copy link
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/40778/

This was referenced Nov 9, 2021
Open
Open
Open
Open
Open
Open
@targos
Copy link
Member Author

targos commented Nov 24, 2021

@nodejs/lts

BethGriggs pushed a commit that referenced this pull request Nov 24, 2021
@targos @BethGriggs
deps: patch V8 to 9.4.146.24
76d1b5d 
Refs: v8/v8@9.4.146.19...9.4.146.24

PR-URL: #40616
Refs: v8/v8@9.4.146.19...9.4.146.23
Reviewed-By: Beth Griggs <[email protected]>
Reviewed-By: Richard Lau <[email protected]>
@BethGriggs
Copy link
Member

Landed in 76d1b5d (v16.x-staging)

@BethGriggs BethGriggs closed this Nov 24, 2021
@targos targos deleted the v8-fixes-v16.x branch November 24, 2021 14:29
@BethGriggs BethGriggs mentioned this pull request Nov 26, 2021
Merged
1 task
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@richardlau richardlau richardlau approved these changes

@BethGriggs BethGriggs BethGriggs approved these changes

Assignees
No one assigned
Labels
needs-ci PRs that need a full CI run. v8 engine Issues and PRs related to the V8 dependency.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@targos @aduh95 @nodejs-github-bot @BethGriggs @richardlau