Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test: compute list of expected globals from ESLint config file #42056

Open
wants to merge 15 commits into
base: main
Choose a base branch
from
Open

test: compute list of expected globals from ESLint config file #42056

Changes from 1 commit
Commits
Show all changes
15 commits
Select commit Hold shift + click to select a range
fbb89f2
test: compute list of expected globals from ESLint config file
aduh95 Feb 22, 2022
9a5ec5f
write json file from python
aduh95 Feb 26, 2022
48e859d
fixup! write json file from python
aduh95 Feb 26, 2022
afdec40
fixup! fixup! write json file from python
aduh95 Feb 26, 2022
5f9d376
lint fix
aduh95 Feb 26, 2022
76b5491
fixup! lint fix
aduh95 Feb 26, 2022
f1cb9bf
fix for tarball
aduh95 Feb 26, 2022
ef7dd44
move to python
aduh95 Feb 27, 2022
8d54abb
copy generated file in the tarball
aduh95 Feb 27, 2022
d85d9b8
fix lint
aduh95 Feb 27, 2022
0446006
don't swallow errors when we don't mean to
aduh95 Feb 27, 2022
c11b45d
fix for `\r` support
aduh95 Feb 27, 2022
642a1ad
fix for tarball
aduh95 Mar 1, 2022
945c835
create JSON file before testing addongs on Windows
aduh95 Mar 1, 2022
9f4470d
respect test-root option
aduh95 Mar 2, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion Makefile
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1140,7 +1140,7 @@ pkg-upload: pkg
scp -p $(TARNAME).pkg $(STAGINGSERVER):nodejs/$(DISTTYPEDIR)/$(FULLVERSION)/$(TARNAME).pkg
ssh $(STAGINGSERVER) "touch nodejs/$(DISTTYPEDIR)/$(FULLVERSION)/$(TARNAME).pkg.done"

$(TARBALL): release-only doc-only
$(TARBALL): release-only doc-only test/common/knownGlobals.json
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This target will also probably need to copy in the generated test/common/knownGlobals.json as the tarball is prepared in $(TARNAME)/ from a fresh git checkout-index.

git checkout-index -a -f --prefix=$(TARNAME)/
mkdir -p $(TARNAME)/doc/api
cp doc/node.1 $(TARNAME)/doc/node.1
Expand All @@ -1159,6 +1159,7 @@ $(TARBALL): release-only doc-only
$(RM) -r $(TARNAME)/deps/v8/tools/run-tests.py
$(RM) -r $(TARNAME)/doc/images # too big
$(RM) -r $(TARNAME)/test*.tap
$(RM) -r $(TARNAME)/test/common/parseEslintConfigForKnownGlobals.js
$(RM) -r $(TARNAME)/tools/cpplint.py
$(RM) -r $(TARNAME)/tools/eslint-rules
$(RM) -r $(TARNAME)/tools/license-builder.sh
Expand Down