Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

readline: fix .question still called after closed #42464

Merged
merged 9 commits into from
Apr 8, 2022
Prev Previous commit
Next Next commit
readline: fix question still called after closed
change according to review
meixg committed Apr 6, 2022
commit 6db86863d6fa3a11a8d7ded2fb75725d2177d494
3 changes: 1 addition & 2 deletions test/parallel/test-readline-interface.js
Original file line number Diff line number Diff line change
@@ -1117,8 +1117,7 @@ for (let i = 0; i < 12; i++) {
assert.strictEqual(name, 'Node.js');
rli.close();
question('How are you?')
.then(common.mustNotCall())
.catch(common.expectsError({
.then(common.mustNotCall(), common.expectsError({
code: 'ERR_READLINE_CLOSED',
name: 'Error'
}));