Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

util: pass on additional error() args #4279

Closed
wants to merge 1 commit into from
Closed
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
util: pass on additional error() args
This fixes breakage introduced in 94b9948 when writing the max
EventEmitter listeners warning to stderr.
mscdex committed Dec 15, 2015
commit 4785e7a54f4aeee0e60e679725831c6ab7afa031
11 changes: 10 additions & 1 deletion lib/internal/util.js
Original file line number Diff line number Diff line change
@@ -18,7 +18,16 @@ exports.printDeprecationMessage = function(msg, warned) {
};

exports.error = function(msg) {
console.error(`${prefix}${msg}`);
const fmt = `${prefix}${msg}`;
if (arguments.length > 1) {
const args = new Array(arguments.length);
args[0] = fmt;
for (let i = 1; i < arguments.length; ++i)
args[i] = arguments[i];
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

why not simply Array.prototype.slice.call(arguments) then args[0] = fmt after?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Because (AFAIK this is still the case) passing arguments to a function other than fn.apply() causes deopts in v8.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ah.. right, keep forgetting about that. carry on then :-)

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Are we avoiding [...arguments] (or function (...rest) args) to make the LTS backporting process easier?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Well if for no other reason than I think spread is slow in v8 still? I am not 100% sure if that changed in v8 4.7 or not...

console.error.apply(console, args);
} else {
console.error(fmt);
}
};

exports.trace = function(msg) {
10 changes: 10 additions & 0 deletions test/parallel/test-util-internal.js
Original file line number Diff line number Diff line change
@@ -4,6 +4,7 @@
const common = require('../common');
const assert = require('assert');
const internalUtil = require('internal/util');
const spawnSync = require('child_process').spawnSync;

function getHiddenValue(obj, name) {
return function() {
@@ -30,3 +31,12 @@ try {
}

assert(/bad_syntax\.js:1/.test(arrowMessage));

const args = [
'--expose-internals',
'-e',
"require('internal/util').error('foo %d', 5)"
];
const result = spawnSync(process.argv[0], args, { encoding: 'utf8' });
assert.strictEqual(result.stderr.indexOf('%'), -1);
assert(/foo 5/.test(result.stderr));