src: reduce cpu profiler overhead #466
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This PR seems to cause a regression on the centos5-64 bot. Investigating. |
|
The centos5-64 kernel is old enough that it doesn't support epoll_pwait(). It's possible the fallback path in libuv is not working as expected. |
|
Fix: libuv/libuv#162 |
|
@bnoordhuis looks like the fixed version of libuv has landed here. |
Reduce the overhead of the CPU profiler by suppressing SIGPROF signals when sleeping / polling for events. Avoids unnecessary wakeups when the CPU profiler is active. The benefits are quite substantial on systems where it is expensive to query the system time (most virtualized environments). Before, it was common to see over 20% of wall clock time being spent on clock_gettime() system calls.
bnoordhuis
force-pushed
the
reduce-cpu-profiler-overhead
branch
from
cfbbf82 to
310ce15
Compare
|
@Fishrock123 Yep. Updated and having the CI check it now: https://jenkins-iojs.nodesource.com/view/iojs/job/iojs+any-pr+multi/130/ |
|
CI is happy. R=@piscisaureus? |
|
taps @piscisaureus on the shoulder |
|
Oh, oops missed this. LGTM |
bnoordhuis
added a commit
that referenced
this pull request
Feb 4, 2015
Reduce the overhead of the CPU profiler by suppressing SIGPROF signals when sleeping / polling for events. Avoids unnecessary wakeups when the CPU profiler is active. The benefits are quite substantial on systems where it is expensive to query the system time (most virtualized environments). Before, it was common to see over 20% of wall clock time being spent on clock_gettime() system calls. PR: #466 Reviewed-by: Bert Belder <[email protected]>
|
Thanks, landed in 96ffcb9. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reduce the overhead of the CPU profiler by suppressing SIGPROF signals
when sleeping / polling for events. Avoids unnecessary wakeups when
the CPU profiler is active.
The benefits are quite substantial on systems where it is expensive to
query the system time (most virtualized environments). Before, it was
common to see over 20% of wall clock time being spent on clock_gettime()
system calls.
R=@piscisaureus