Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

node-api: verify cleanup hooks order #46692

Closed
wants to merge 1 commit into from
Closed

node-api: verify cleanup hooks order #46692

wants to merge 1 commit into from

Conversation

legendecas
Copy link
Member

@legendecas legendecas commented Feb 17, 2023 •
edited
Loading

Cleanup hooks are called before the environment shutdown finalizer
invocations.

/cc @nodejs/node-api

@legendecas legendecas added test Issues and PRs related to the tests. node-api Issues and PRs related to the Node-API. labels Feb 17, 2023
@nodejs-github-bot nodejs-github-bot added the needs-ci PRs that need a full CI run. label Feb 17, 2023
@legendecas legendecas mentioned this pull request Feb 17, 2023
Merged
@legendecas legendecas added the request-ci Add this label to start a Jenkins CI on a PR. label Feb 20, 2023
@github-actions github-actions bot removed the request-ci Add this label to start a Jenkins CI on a PR. label Feb 20, 2023
@nodejs-github-bot
Copy link
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/49759/

@nodejs-github-bot
Copy link
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/49785/

This was referenced Feb 21, 2023
Open
Open
mhdawson
mhdawson approved these changes Feb 23, 2023
View reviewed changes
Copy link
Member

@mhdawson mhdawson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@nodejs-github-bot
Copy link
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/49943/

@KevinEady KevinEady mentioned this pull request Feb 24, 2023
Closed
@nodejs-github-bot
Copy link
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/50171/

@github-actions github-actions bot mentioned this pull request Mar 3, 2023
Open
18 tasks
@legendecas
Copy link
Member Author

legendecas commented Mar 3, 2023 •
edited
Loading

It seems like the test is only failing on the alpine build. I'll take a look at it.

This was referenced Mar 4, 2023
Open
Open
Open
Open
@legendecas legendecas added the request-ci Add this label to start a Jenkins CI on a PR. label Mar 9, 2023
@github-actions github-actions bot added request-ci-failed An error occurred while starting CI via request-ci label, and manual interventon is needed. and removed request-ci Add this label to start a Jenkins CI on a PR. labels Mar 9, 2023
@github-actions
Copy link
Contributor

github-actions bot commented Mar 9, 2023

Failed to start CI
- Validating Jenkins credentials
✔  Jenkins credentials valid
- Starting PR CI job
✘  Failed to start PR CI: 403 Forbidden
https://github.com/nodejs/node/actions/runs/4376492148

@legendecas
node-api: verify cleanup hooks order
2f01895 
Cleanup hooks are called before the environment shutdown finalizer
invocations.
@legendecas legendecas force-pushed the node-api/cleanup-order branch from 3dd11d2 to 2f01895 Compare March 9, 2023 16:19
@aduh95 aduh95 added request-ci Add this label to start a Jenkins CI on a PR. and removed request-ci-failed An error occurred while starting CI via request-ci label, and manual interventon is needed. labels Mar 9, 2023
@github-actions github-actions bot mentioned this pull request Mar 10, 2023
Open
22 tasks
@legendecas legendecas added the request-ci Add this label to start a Jenkins CI on a PR. label Mar 10, 2023
@github-actions github-actions bot removed the request-ci Add this label to start a Jenkins CI on a PR. label Mar 10, 2023
This was referenced Mar 11, 2023
Open
Open
@legendecas legendecas added the request-ci Add this label to start a Jenkins CI on a PR. label Mar 12, 2023
@github-actions github-actions bot removed the request-ci Add this label to start a Jenkins CI on a PR. label Mar 12, 2023
@nodejs-github-bot
Copy link
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/50339/

@github-actions github-actions bot mentioned this pull request Mar 13, 2023
Open
20 tasks
@nodejs-github-bot
Copy link
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/50342/

@nodejs-github-bot
Copy link
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/50344/

@nodejs-github-bot
Copy link
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/50348/

@github-actions github-actions bot mentioned this pull request Mar 14, 2023
Open
24 tasks
@nodejs-github-bot
Copy link
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/50372/

@nodejs-github-bot
Copy link
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/50379/

legendecas added a commit that referenced this pull request Mar 14, 2023
@legendecas
node-api: verify cleanup hooks order
b80ab31 
Cleanup hooks are called before the environment shutdown finalizer
invocations.

PR-URL: #46692
Reviewed-By: Colin Ihrig <[email protected]>
Reviewed-By: James M Snell <[email protected]>
Reviewed-By: Michael Dawson <[email protected]>
@legendecas
Copy link
Member Author

Landed in b80ab31

@legendecas legendecas closed this Mar 14, 2023
@legendecas legendecas deleted the node-api/cleanup-order branch March 14, 2023 16:58
This was referenced Mar 15, 2023
Open
Open
Open
Open
targos pushed a commit that referenced this pull request Mar 18, 2023
@legendecas @targos
node-api: verify cleanup hooks order
b3fe2ba 
Cleanup hooks are called before the environment shutdown finalizer
invocations.

PR-URL: #46692
Reviewed-By: Colin Ihrig <[email protected]>
Reviewed-By: James M Snell <[email protected]>
Reviewed-By: Michael Dawson <[email protected]>
@github-actions github-actions bot mentioned this pull request Mar 19, 2023
Open
19 tasks
This was referenced Apr 3, 2023
Merged
Merged
@toyobayashi toyobayashi mentioned this pull request Apr 19, 2023
Merged
danielleadams pushed a commit that referenced this pull request Jul 6, 2023
@legendecas @danielleadams
node-api: verify cleanup hooks order
d8d2d33 
Cleanup hooks are called before the environment shutdown finalizer
invocations.

PR-URL: #46692
Reviewed-By: Colin Ihrig <[email protected]>
Reviewed-By: James M Snell <[email protected]>
Reviewed-By: Michael Dawson <[email protected]>
@danielleadams danielleadams mentioned this pull request Jul 10, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jasnell jasnell jasnell approved these changes

@cjihrig cjihrig cjihrig approved these changes

@mhdawson mhdawson mhdawson approved these changes

Assignees
No one assigned
Labels
needs-ci PRs that need a full CI run. node-api Issues and PRs related to the Node-API. test Issues and PRs related to the tests.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@legendecas @nodejs-github-bot @jasnell @cjihrig @mhdawson @aduh95