Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

tools: fix update-undici.sh path #50163

Closed
wants to merge 2 commits into from
Closed

tools: fix update-undici.sh path #50163

wants to merge 2 commits into from

Conversation

Keksonoid
Copy link
Contributor

Fixes: #50159

@nodejs-github-bot
Copy link
Collaborator

Review requested:

  • @nodejs/security-wg

@nodejs-github-bot nodejs-github-bot added c++ Issues and PRs that require attention from people who are familiar with C++. needs-ci PRs that need a full CI run. tools Issues and PRs related to the tools directory. labels Oct 12, 2023
@marco-ippolito
Copy link
Member

Please amend your commit message to tools: fix update-undici.sh path following the commit convention

@Keksonoid Keksonoid changed the title Fixes: update undici_version.h and update-acorn.sh tools: fix update-undici.sh path Oct 12, 2023
@Keksonoid Keksonoid closed this Oct 12, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
c++ Issues and PRs that require attention from people who are familiar with C++. needs-ci PRs that need a full CI run. tools Issues and PRs related to the tools directory.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

undici_version.h and acorn_version.h displaying wrong update script path
3 participants
@Keksonoid @nodejs-github-bot @marco-ippolito