Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

node-api: refactor napi_set_property function for improved performance #51042

Closed
wants to merge 31 commits into from
Closed
Changes from 1 commit
Commits
Show all changes
31 commits
Select commit Hold shift + click to select a range
f686b2e
node-api: refactor napi set property function for improved performance
Oct 19, 2023
6d66cbd
fix: lint
Oct 25, 2023
4ecd631
fix: lint
Oct 25, 2023
b36b9f7
refactor: Improve performance by using internalized property keys
Nov 6, 2023
44641af
refactor: Update node_api_create_property_key_utf16 signature and rem…
Nov 6, 2023
dab9544
lint
Nov 6, 2023
8cf75bc
lint
Nov 6, 2023
202cdaa
fix: Resolve compilation error in node_api_create_property_key_utf16
Nov 6, 2023
da9371c
fix: Resolve type conversion error in node_api_create_property_key_utf16
Nov 6, 2023
9e9653c
refactor: Simplify node_api_create_property_key_utf16 implementation
Nov 7, 2023
f7ab085
lint
Nov 7, 2023
d072933
add node_api_create_property_key_utf16 property name
Nov 12, 2023
382f3e0
added doc for node_api_create_property_key_utf16
Nov 12, 2023
c2549f5
lint
Nov 12, 2023
ee9ea43
lint
Nov 12, 2023
f999ad2
update napi doc for node_api_create_property_key_utf16
Nov 13, 2023
6a5bdc7
update: code snipet
Nov 13, 2023
3ad361b
test: added test for node_api_create_property_key_utf16
Nov 13, 2023
99e3ae5
lint
Nov 13, 2023
05f7ab0
lint
Nov 13, 2023
fe733db
lint
Nov 13, 2023
89cb720
Update doc/api/n-api.md
mertcanaltin Nov 19, 2023
8179670
Update test/js-native-api/test_string/test_string.c
mertcanaltin Nov 19, 2023
e7bbd09
Update test/js-native-api/test_string/test_string.c
mertcanaltin Nov 19, 2023
f5d252e
Update doc/api/n-api.md
mertcanaltin Nov 19, 2023
555ba66
call node_api_create_property_key_utf16
Nov 19, 2023
6218c05
Merge branch '49922-dev' of https://github.com/mertcanaltin/node into…
Nov 19, 2023
fcfa24c
added TestPropertyKeyUtf16 napi_property_descriptor
Nov 19, 2023
f448405
lint doc
Nov 19, 2023
cc8ba66
lint cpp
Nov 19, 2023
70e02d8
minor updates to PR #50282
vmoroz Dec 3, 2023
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
fix: Resolve compilation error in node_api_create_property_key_utf16
mert.altin committed Nov 6, 2023
commit 202cdaae0fb9a74c68066cf811c000bdca050012
2 changes: 1 addition & 1 deletion src/js_native_api_v8.cc
Original file line number Diff line number Diff line change
@@ -1123,7 +1123,7 @@ napi_status node_api_create_property_key_utf16(napi_env env,
static_cast<int>(length))
.ToLocalChecked();

v8impl::JsValueFromV8LocalValue(*result, k);
*result = k;

return napi_ok;
}