repl: accept no arguments to start() #5388
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
LGTM |
|
What is the game plan for landing code changes while Jenkins is offline? Should we just wait until it's back to use the normal CI flow? |
|
I think that would be best. |
Fishrock123
added
the
semver-minor
|
LGTM, we should be holding for CI I think. |
|
LGTM with a minor nit, doc should be updated to specify |
Currently, there is a check to ensure that the user either provides an object or a string to repl.start(). The string case is used to set a REPL prompt. However, a default of '> ' already exists, so forcing the user to specify a prompt is a bit redundant. This commit removes this restriction. Fixes: nodejs#5385 PR-URL: nodejs#5388 Reviewed-By: Ben Noordhuis <[email protected]> Reviewed-By: Jeremiah Senkpiel <[email protected]> Reviewed-By: Julian Duque <[email protected]>
|
Addressed @julianduque comment. CI is green - https://ci.nodejs.org/job/node-test-pull-request/1748/. Landing. Thanks for the reviews. |
2 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently, there is a check to ensure that the user either provides an object or a string to
repl.start(). The string case is used to set a REPL prompt. However, a default of'> 'already exists, so forcing the user to specify a prompt is a bit redundant. This commit removes this restriction.Closes #5385