Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

test_runner: mark snapshot testing as stable #55897

Merged
merged 1 commit into from
Nov 19, 2024
Merged

test_runner: mark snapshot testing as stable #55897

merged 1 commit into from
Nov 19, 2024

Conversation

cjihrig
Copy link
Contributor

@cjihrig cjihrig commented Nov 17, 2024

This commit marks the test runner's snapshot testing API as stable.

Snapshot testing has been available for over 5 months. There are no open issues related to it.

@nodejs-github-bot
Copy link
Collaborator

Review requested:

  • @nodejs/test_runner

@nodejs-github-bot nodejs-github-bot added c++ Issues and PRs that require attention from people who are familiar with C++. needs-ci PRs that need a full CI run. test_runner Issues and PRs related to the test runner subsystem. labels Nov 17, 2024
@codecov Codecov
Copy link

codecov bot commented Nov 17, 2024 •
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 88.43%. Comparing base (1618463) to head (78b974b).
Report is 13 commits behind head on main.

Additional details and impacted files 
@@            Coverage Diff             @@
##             main   #55897      +/-   ##
==========================================
+ Coverage   87.93%   88.43%   +0.50%     
==========================================
  Files         654      654              
  Lines      187860   187853       -7     
  Branches    35840    36147     +307     
==========================================
+ Hits       165196   166131     +935     
+ Misses      15863    14973     -890     
+ Partials     6801     6749      -52
Files with missing lines Coverage Δ
lib/internal/test_runner/test.js 96.97% <100.00%> (-0.01%) ⬇️
lib/test.js 100.00% <100.00%> (ø)
src/node_options.cc 87.46% <100.00%> (ø)
src/node_options.h 98.26% <ø> (-0.01%) ⬇️

... and 98 files with indirect coverage changes

---- 🚨 Try these New Features:

MoLow
MoLow reviewed Nov 17, 2024
View reviewed changes
@cjihrig
test_runner: mark snapshot testing as stable
78b974b 
This commit marks the test runner's snapshot testing API as
stable.
mcollina
mcollina approved these changes Nov 17, 2024
View reviewed changes
Copy link
Member

@mcollina mcollina left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@cjihrig cjihrig added the request-ci Add this label to start a Jenkins CI on a PR. label Nov 18, 2024
@github-actions github-actions bot removed the request-ci Add this label to start a Jenkins CI on a PR. label Nov 18, 2024
@nodejs-github-bot
Copy link
Collaborator

nodejs-github-bot commented Nov 18, 2024 •
edited by cjihrig
Loading

CI: https://ci.nodejs.org/job/node-test-pull-request/63612/ 🟢

@cjihrig cjihrig added author ready PRs that have at least one approval, no pending requests for changes, and a CI started. commit-queue Add this label to land a pull request using GitHub Actions. and removed needs-ci PRs that need a full CI run. labels Nov 18, 2024
@nodejs-github-bot nodejs-github-bot removed the commit-queue Add this label to land a pull request using GitHub Actions. label Nov 19, 2024
@nodejs-github-bot nodejs-github-bot merged commit c921676 into nodejs:main Nov 19, 2024
63 checks passed
@nodejs-github-bot
Copy link
Collaborator

Landed in c921676

@cjihrig cjihrig deleted the test-snapshots branch November 19, 2024 17:47
tpoisseau pushed a commit to tpoisseau/node that referenced this pull request Nov 21, 2024
@cjihrig @tpoisseau
test_runner: mark snapshot testing as stable
1431203 
This commit marks the test runner's snapshot testing API as
stable.

PR-URL: nodejs#55897
Reviewed-By: Moshe Atlow <[email protected]>
Reviewed-By: Pietro Marchini <[email protected]>
Reviewed-By: Matteo Collina <[email protected]>
Reviewed-By: Jacob Smith <[email protected]>
Reviewed-By: Chemi Atlow <[email protected]>
Ceres6 pushed a commit to Ceres6/node that referenced this pull request Nov 26, 2024
@cjihrig @Ceres6
test_runner: mark snapshot testing as stable
d243a5f 
This commit marks the test runner's snapshot testing API as
stable.

PR-URL: nodejs#55897
Reviewed-By: Moshe Atlow <[email protected]>
Reviewed-By: Pietro Marchini <[email protected]>
Reviewed-By: Matteo Collina <[email protected]>
Reviewed-By: Jacob Smith <[email protected]>
Reviewed-By: Chemi Atlow <[email protected]>
aduh95 pushed a commit that referenced this pull request Nov 26, 2024
@cjihrig @aduh95
test_runner: mark snapshot testing as stable
8197815 
This commit marks the test runner's snapshot testing API as
stable.

PR-URL: #55897
Reviewed-By: Moshe Atlow <[email protected]>
Reviewed-By: Pietro Marchini <[email protected]>
Reviewed-By: Matteo Collina <[email protected]>
Reviewed-By: Jacob Smith <[email protected]>
Reviewed-By: Chemi Atlow <[email protected]>
This was referenced Nov 28, 2024
Closed
Closed
Closed
This was referenced Nov 28, 2024
Closed
Closed
Closed
Closed
Closed
Closed
Closed
This was referenced Nov 28, 2024
Closed
Closed
Closed
Closed
Closed
@nodejs-github-bot nodejs-github-bot mentioned this pull request Dec 3, 2024
Merged
@github-actions github-actions bot mentioned this pull request Dec 6, 2024
Closed
aduh95 pushed a commit that referenced this pull request Dec 10, 2024
@cjihrig @aduh95
test_runner: mark snapshot testing as stable
618d451 
This commit marks the test runner's snapshot testing API as
stable.

PR-URL: #55897
Reviewed-By: Moshe Atlow <[email protected]>
Reviewed-By: Pietro Marchini <[email protected]>
Reviewed-By: Matteo Collina <[email protected]>
Reviewed-By: Jacob Smith <[email protected]>
Reviewed-By: Chemi Atlow <[email protected]>
This was referenced Dec 11, 2024
Closed
Closed
@ruyadorno ruyadorno mentioned this pull request Dec 20, 2024
Merged
cjihrig added a commit to cjihrig/node that referenced this pull request Jan 1, 2025
@cjihrig
test_runner: finish marking snapshot testing as stable
84b8c1e 
Snapshot testing was marked stable in nodejs#55897. These were
overlooked at the time.

Refs: nodejs#55897
@cjihrig cjihrig mentioned this pull request Jan 1, 2025
Merged
cjihrig added a commit to cjihrig/node that referenced this pull request Jan 2, 2025
@cjihrig
test_runner: finish marking snapshot testing as stable
08e500f 
Snapshot testing was marked stable in nodejs#55897. These were
overlooked at the time.

Refs: nodejs#55897
nodejs-github-bot pushed a commit that referenced this pull request Jan 3, 2025
@cjihrig
test_runner: finish marking snapshot testing as stable
afafee2 
Snapshot testing was marked stable in #55897. These were
overlooked at the time.

Refs: #55897
PR-URL: #56425
Reviewed-By: Yagiz Nizipli <[email protected]>
Reviewed-By: Chemi Atlow <[email protected]>
Reviewed-By: Jacob Smith <[email protected]>
Reviewed-By: Pietro Marchini <[email protected]>
Reviewed-By: Moshe Atlow <[email protected]>
ruyadorno pushed a commit that referenced this pull request Jan 5, 2025
@cjihrig @ruyadorno
test_runner: mark snapshot testing as stable
8ff082c 
This commit marks the test runner's snapshot testing API as
stable.

PR-URL: #55897
Reviewed-By: Moshe Atlow <[email protected]>
Reviewed-By: Pietro Marchini <[email protected]>
Reviewed-By: Matteo Collina <[email protected]>
Reviewed-By: Jacob Smith <[email protected]>
Reviewed-By: Chemi Atlow <[email protected]>
targos pushed a commit that referenced this pull request Jan 13, 2025
@cjihrig @targos
test_runner: finish marking snapshot testing as stable
228c741 
Snapshot testing was marked stable in #55897. These were
overlooked at the time.

Refs: #55897
PR-URL: #56425
Reviewed-By: Yagiz Nizipli <[email protected]>
Reviewed-By: Chemi Atlow <[email protected]>
Reviewed-By: Jacob Smith <[email protected]>
Reviewed-By: Pietro Marchini <[email protected]>
Reviewed-By: Moshe Atlow <[email protected]>
aduh95 pushed a commit that referenced this pull request Jan 31, 2025
@cjihrig @aduh95
test_runner: finish marking snapshot testing as stable
c7f3462 
Snapshot testing was marked stable in #55897. These were
overlooked at the time.

Refs: #55897
PR-URL: #56425
Reviewed-By: Yagiz Nizipli <[email protected]>
Reviewed-By: Chemi Atlow <[email protected]>
Reviewed-By: Jacob Smith <[email protected]>
Reviewed-By: Pietro Marchini <[email protected]>
Reviewed-By: Moshe Atlow <[email protected]>
aduh95 pushed a commit that referenced this pull request Feb 4, 2025
@cjihrig @aduh95
test_runner: finish marking snapshot testing as stable
fb4661a 
Snapshot testing was marked stable in #55897. These were
overlooked at the time.

Refs: #55897
PR-URL: #56425
Reviewed-By: Yagiz Nizipli <[email protected]>
Reviewed-By: Chemi Atlow <[email protected]>
Reviewed-By: Jacob Smith <[email protected]>
Reviewed-By: Pietro Marchini <[email protected]>
Reviewed-By: Moshe Atlow <[email protected]>
mcollina pushed a commit to mcollina/node that referenced this pull request Mar 13, 2025
@cjihrig @RafaelGSS
test_runner: finish marking snapshot testing as stable
3aa8649 
Snapshot testing was marked stable in nodejs#55897. These were
overlooked at the time.

Refs: nodejs#55897
PR-URL: nodejs#56425
Reviewed-By: Yagiz Nizipli <[email protected]>
Reviewed-By: Chemi Atlow <[email protected]>
Reviewed-By: Jacob Smith <[email protected]>
Reviewed-By: Pietro Marchini <[email protected]>
Reviewed-By: Moshe Atlow <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mcollina mcollina mcollina approved these changes

@JakobJingleheimer JakobJingleheimer JakobJingleheimer approved these changes

@MoLow MoLow MoLow approved these changes

@pmarchini pmarchini pmarchini approved these changes

@atlowChemi atlowChemi atlowChemi approved these changes

Assignees
No one assigned
Labels
author ready PRs that have at least one approval, no pending requests for changes, and a CI started. c++ Issues and PRs that require attention from people who are familiar with C++. test_runner Issues and PRs related to the test runner subsystem.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
7 participants
@cjihrig @nodejs-github-bot @mcollina @JakobJingleheimer @MoLow @pmarchini @atlowChemi