Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

doc: deprecate passing args to spawn and execFile #57389

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

doc: deprecate passing args to spawn and execFile #57389

wants to merge 1 commit into from
+15 −0

Conversation

aduh95
Copy link
Contributor

@aduh95 aduh95 commented Mar 9, 2025

Refs: #57199

@nodejs-github-bot nodejs-github-bot added deprecations Issues and PRs related to deprecations. doc Issues and PRs related to the documentations. labels Mar 9, 2025
jasnell
jasnell reviewed Mar 9, 2025
View reviewed changes
doc/api/deprecations.md
changes:
- version:
- REPLACEME
pr-url: https://github.com/nodejs/node/pull/57199
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
pr-url: https://github.com/nodejs/node/pull/57199
pr-url: https://github.com/nodejs/node/pull/57389

Copy link
Member

@jazelly jazelly Mar 9, 2025 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think 57199 is the source implementation, which effectively deprecates passing args with truthy options.shell. Referring to 57199 probably makes more sense.

jazelly
jazelly approved these changes Mar 9, 2025
View reviewed changes
doc/api/deprecations.md
changes:
- version:
- REPLACEME
pr-url: https://github.com/nodejs/node/pull/57199
Copy link
Member

@jazelly jazelly Mar 9, 2025 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think 57199 is the source implementation, which effectively deprecates passing args with truthy options.shell. Referring to 57199 probably makes more sense.

@DanielVenable
Copy link
Contributor

The lint error can be fixed with the same change as used here: c885d04

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jasnell jasnell jasnell approved these changes

@lpinca lpinca lpinca approved these changes

@UlisesGascon UlisesGascon UlisesGascon approved these changes

@jazelly jazelly jazelly approved these changes

Assignees
No one assigned
Labels
deprecations Issues and PRs related to deprecations. doc Issues and PRs related to the documentations.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
7 participants
@aduh95 @DanielVenable @jasnell @lpinca @UlisesGascon @jazelly @nodejs-github-bot