Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[v23.x] deps: update undici to 6.21.2 #57442

Merged
merged 1 commit into from
Mar 28, 2025
Merged

[v23.x] deps: update undici to 6.21.2 #57442

merged 1 commit into from
Mar 28, 2025
+29 −6

Conversation

mcollina
Copy link
Member

This should be updated to v23.x, v22.x and v20.x

@mcollina mcollina requested a review from a team March 13, 2025 12:21
@nodejs-github-bot
Copy link
Collaborator

Review requested:

  • @nodejs/security-wg

@nodejs-github-bot nodejs-github-bot added lib / src Issues and PRs related to general changes in the lib or src directory. needs-ci PRs that need a full CI run. v23.x v23.x Issues that can be reproduced on v23.x or PRs targeting the v23.x-staging branch. labels Mar 13, 2025
@marco-ippolito marco-ippolito changed the title deps: update undici to 6.21.2 [v23.x backport] deps: update undici to 6.21.2 Mar 13, 2025
@codecov Codecov
Copy link

codecov bot commented Mar 13, 2025 •
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 90.26%. Comparing base (89ec118) to head (162b282).
Report is 91 commits behind head on v23.x-staging.

Additional details and impacted files 
@@                Coverage Diff                @@
##           v23.x-staging   #57442      +/-   ##
=================================================
- Coverage          90.26%   90.26%   -0.01%     
=================================================
  Files                630      631       +1     
  Lines             185124   185076      -48     
  Branches           36256    36253       -3     
=================================================
- Hits              167110   167054      -56     
- Misses             10986    10993       +7     
- Partials            7028     7029       +1

see 42 files with indirect coverage changes

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@aduh95 aduh95 changed the title [v23.x backport] deps: update undici to 6.21.2 [v23.x] deps: update undici to 6.21.2 Mar 13, 2025
aduh95
aduh95 approved these changes Mar 14, 2025
View reviewed changes
Copy link
Contributor

@aduh95 aduh95 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

RSLGTM

@aduh95 aduh95 added lts-watch-v20.x PRs that may need to be released in v20.x request-ci Add this label to start a Jenkins CI on a PR. labels Mar 14, 2025
@github-actions github-actions bot removed the request-ci Add this label to start a Jenkins CI on a PR. label Mar 14, 2025
@nodejs-github-bot
Copy link
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/65744/

@nodejs-github-bot
Copy link
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/65753/

@mcollina mcollina added the request-ci Add this label to start a Jenkins CI on a PR. label Mar 14, 2025
@github-actions github-actions bot removed the request-ci Add this label to start a Jenkins CI on a PR. label Mar 14, 2025
@nodejs-github-bot
Copy link
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/65755/

@nodejs-github-bot
Copy link
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/65847/

@RafaelGSS RafaelGSS added the lts-watch-v22.x PRs that may need to be released in v22.x label Mar 28, 2025
@mcollina @aduh95
deps: update undici to 6.21.2
162b282 
Signed-off-by: Matteo Collina <[email protected]>
PR-URL: nodejs#57442
Reviewed-By: Antoine du Hamel <[email protected]>
Reviewed-By: Rafael Gonzaga <[email protected]>
@aduh95 aduh95 force-pushed the update-undici-23-quater branch from 89ec118 to 162b282 Compare March 28, 2025 18:48
@aduh95 aduh95 merged commit 162b282 into nodejs:v23.x-staging Mar 28, 2025
20 checks passed
@github-actions github-actions bot mentioned this pull request Mar 30, 2025
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@aduh95 aduh95 aduh95 approved these changes

@RafaelGSS RafaelGSS RafaelGSS approved these changes

Assignees
No one assigned
Labels
lib / src Issues and PRs related to general changes in the lib or src directory. lts-watch-v20.x PRs that may need to be released in v20.x lts-watch-v22.x PRs that may need to be released in v22.x needs-ci PRs that need a full CI run. v23.x v23.x Issues that can be reproduced on v23.x or PRs targeting the v23.x-staging branch.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@mcollina @nodejs-github-bot @aduh95 @RafaelGSS