src: force gc for flaky (deadlock) tests #57476
Closed
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This patch adds a new flag
force_gc_for_test
(internal use for test purpose only) to force GC for flaky tests that suffer from deadlock. Refs: #54918 and #56827 (comment)The deadlock occurs when (correct me if I am wrong):
Notes:
RequestGarbageCollectionForTesting
will require--expose-gc
flag to work which means for the flaky tests that suffer from deadlock we will need// Flags: --expose-gc --force-gc-for-test
at the top of the test file.