Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[v18.x backport] build: update gcovr to 7.2 and codecov config #57565

Open
wants to merge 1 commit into
base: v18.x-staging
Choose a base branch
from
Open

[v18.x backport] build: update gcovr to 7.2 and codecov config #57565

wants to merge 1 commit into from
+17 −17

Conversation

richardlau
Copy link
Member

PR-URL: #54019
Reviewed-By: Yagiz Nizipli [email protected]
Reviewed-By: James M Snell [email protected]
Reviewed-By: Michaël Zasso [email protected]

Opening to see if backporting this fixes the coverage workflows for v18.x-staging.

@bcoe @richardlau
build: update gcovr to 7.2 and codecov config
3d76975 
PR-URL: #54019
Reviewed-By: Yagiz Nizipli <[email protected]>
Reviewed-By: James M Snell <[email protected]>
Reviewed-By: Michaël Zasso <[email protected]>
@nodejs-github-bot
Copy link
Collaborator

Review requested:

  • @nodejs/actions

@nodejs-github-bot nodejs-github-bot added build Issues and PRs related to build files or the CI. meta Issues and PRs related to the general management of the project. needs-ci PRs that need a full CI run. v18.x Issues that can be reproduced on v18.x or PRs targeting the v18.x-staging branch. labels Mar 20, 2025
@richardlau richardlau mentioned this pull request Mar 20, 2025
Open
@richardlau richardlau added the fast-track PRs that do not need to wait for 48 hours to land. label Mar 20, 2025
@github-actions GitHub Actions
Copy link
Contributor

Fast-track has been requested by @richardlau. Please 👍 to approve.

@richardlau
Copy link
Member Author

cc @nodejs/releasers

It looks like this fixes the failing coverage builds on v18.x-staging (see #57557).

Requesting fast track so I can include it in the Node.js 18 I am preparing, or we can decide not to fix it this close to Node.js 18's End-of-Life.

@richardlau richardlau added the request-ci Add this label to start a Jenkins CI on a PR. label Mar 20, 2025
@github-actions github-actions bot removed the request-ci Add this label to start a Jenkins CI on a PR. label Mar 20, 2025
@nodejs-github-bot
Copy link
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/65853/

@nodejs-github-bot
Copy link
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/65856/

@nodejs-github-bot

This comment was marked as outdated.

Sign in to view
@nodejs-github-bot
Copy link
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/65860/

@nodejs-github-bot
Copy link
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/65863/

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@targos targos targos approved these changes

@BridgeAR BridgeAR BridgeAR approved these changes

Assignees
No one assigned
Labels
build Issues and PRs related to build files or the CI. fast-track PRs that do not need to wait for 48 hours to land. meta Issues and PRs related to the general management of the project. needs-ci PRs that need a full CI run. v18.x Issues that can be reproduced on v18.x or PRs targeting the v18.x-staging branch.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@richardlau @nodejs-github-bot @targos @BridgeAR @bcoe