Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix crypto-rsa code #57572

Open
wants to merge 4 commits into
base: main
Choose a base branch
from
Open

Fix crypto-rsa code #57572

wants to merge 4 commits into from
+66 −5

Conversation

AmitPrajapati-1
Copy link

No description provided.

@nodejs-github-bot
Copy link
Collaborator

Review requested:

  • @nodejs/crypto

@nodejs-github-bot nodejs-github-bot added c++ Issues and PRs that require attention from people who are familiar with C++. crypto Issues and PRs related to the crypto subsystem. needs-ci PRs that need a full CI run. labels Mar 21, 2025
This was referenced Mar 21, 2025
Closed
Open
panva
panva requested changes Mar 21, 2025
View reviewed changes
Copy link
Member

@panva panva left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This does not fix the underlying issue introduced somewhere in the ncrypto refactors. Checking that all bytes are 0 and then returning a zero-byte buffer is not a fix to the issue and it introduces more edge cases than it solves. i.e. an n-byte empty buffer will now always return 0-byte buffer.

#57553 (comment)

aduh95
aduh95 reviewed Mar 21, 2025
View reviewed changes
package-lock.json
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could you please remove this?

aduh95
aduh95 reviewed Mar 21, 2025
View reviewed changes
test/parallel/package-lock.json
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could you please remove this?

@AmitPrajapati-1
Copy link
Author

rather than converting empty string. we can Throwing appropriate errors with meaningful messages instead of trying to handle empty strings by returning zero-byte buffers.

@AmitPrajapati-1 AmitPrajapati-1 requested a review from panva March 21, 2025 08:58
panva
panva requested changes Mar 21, 2025
View reviewed changes
Copy link
Member

@panva panva left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

My original review stands.

panva added a commit to panva/node that referenced this pull request Mar 21, 2025
@panva
crypto: fix output of privateDecrypt with zero-length data
057f4c5 
closes nodejs#57553
closes nodejs#57572
closes nodejs#57558
@panva panva mentioned this pull request Mar 21, 2025
Open
@panva
Copy link
Member

panva commented Mar 21, 2025

Fix in #57575

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@aduh95 aduh95 aduh95 left review comments

@panva panva panva requested changes

Assignees
No one assigned
Labels
c++ Issues and PRs that require attention from people who are familiar with C++. crypto Issues and PRs related to the crypto subsystem. needs-ci PRs that need a full CI run.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@AmitPrajapati-1 @nodejs-github-bot @panva @aduh95