-
Notifications
You must be signed in to change notification settings - Fork 31.3k
esm: implement import.meta.main #57804
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
Review requested:
|
135a7a1
to
f31d130
Compare
@ljharb I would appreciate your review on this r.e. performance - I am particularly concerned about my changes in lib/internal/modules/esm/translators.js, since I'm not familiar with implications of assignment to a JS object associated with a native object. |
5452731
to
b677069
Compare
6bdcad8
to
6613f1d
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #57804 +/- ##
==========================================
+ Coverage 90.21% 90.24% +0.03%
==========================================
Files 630 630
Lines 185518 185680 +162
Branches 36383 36398 +15
==========================================
+ Hits 167360 167573 +213
+ Misses 11033 11000 -33
+ Partials 7125 7107 -18
🚀 New features to boost your workflow:
|
Boolean value to check if an ES Module is the entrypoint of the current process. Implements: nodejs#57226 Co-authored-by: Antoine du Hamel <[email protected]>
Co-authored-by: Marco Ippolito <[email protected]>
c4619a4
to
eb4e8a7
Compare
@ljharb I've moved the assignment into I think I can see where the cache is populated, but not where it is hit in What am I missing? |
Co-authored-by: Jordan Harband <[email protected]>
I think CI should pass now. |
I checked locally, it seems the test no longer fails with unusual character names using a relative import path. |
Implements #57226
This PR supersedes #32223
Fixes: #57226