[WIP] node-api: optimize finalizer queue using container swap

[mertcanaltin]

I replaced the iterative per-item removal with a swap to reduce the overhead

[nodejs-github-bot]

Review requested:

• @nodejs/node-api

[codecov]

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 90.24%. Comparing base (964e41c) to head (b9521e8).
Report is 33 commits behind head on main.

Additional details and impacted files

@@           Coverage Diff            @@
##             main   #57861    +/-   ##
========================================
  Coverage   90.23%   90.24%            
========================================
  Files         630      630            
  Lines      185518   185935   +417     
  Branches    36369    36439    +70     
========================================
+ Hits       167401   167789   +388     
- Misses      11005    11009     +4     
- Partials     7112     7137    +25     

Files with missing lines	Coverage Δ
src/node_api.cc	76.19% <100.00%> (+0.05%)	⬆️

... and 54 files with indirect coverage changes

🚀 New features to boost your workflow:

• ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
• 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

[legendecas]

The assumption in the comment "userland code can delete additional references in one finalizer" will break with the new change.

However, this assumption was not reflected in test test/js-native-api/6_object_wrap/6_object_wrap.cc. Would you mind updating the test to verify deleting another reference in the destructor of MyObject?

MyObject::~MyObject() {
  napi_delete_reference(env_, nested_);
  napi_delete_reference(env_, wrapper_);
}

[mertcanaltin]

The assumption in the comment "userland code can delete additional references in one finalizer" will break with the new change.

However, this assumption was not reflected in test test/js-native-api/6_object_wrap/6_object_wrap.cc. Would you mind updating the test to verify deleting another reference in the destructor of MyObject?

MyObject::~MyObject() {
  napi_delete_reference(env_, nested_);
  napi_delete_reference(env_, wrapper_);
}

I updated, thanks

[mertcanaltin]

tests passed in my local environment for macos but I think there is a problem in linux I will try