-
Notifications
You must be signed in to change notification settings - Fork 31.3k
repl: fix multiline history editing string order #57874
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
repl: fix multiline history editing string order #57874
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Would this also fix the flaky behavior reported in the comment? :)
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #57874 +/- ##
==========================================
- Coverage 90.24% 90.24% -0.01%
==========================================
Files 630 630
Lines 185670 185694 +24
Branches 36401 36404 +3
==========================================
+ Hits 167567 167577 +10
- Misses 10992 10999 +7
- Partials 7111 7118 +7
🚀 New features to boost your workflow:
|
50800d0
to
39b827c
Compare
I just added some code which could fix the flakiness... I am not sure if it is good / clean enough tho, I didn't have any cooler idea 😞 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I don't think the wait should make a difference for the test being flaky. I could imagine we run tests in parallel that use the same repl file to write to and they conflict with each other. Or is that unique to the current tmp directory?
The flaky result said we had two history entries.
Yeah I interpreted the two history entries as in a weird combination of keypresses which were not properly "awaited" for. Unfortunately I cannot reproduce the issue, let me investigate the "multiple access to the same history file" path EDIT: applied your suggestion, let's see if it happens again! |
39b827c
to
4a9c482
Compare
4a9c482
to
84f0885
Compare
84f0885
to
03cd310
Compare
Landed in af85f3f |
fixing an issue introduced in the last commit of #57400:
when editing a multiline history in REPL, the string gets reversed.
Added relevant automated tests