-
-
Notifications
You must be signed in to change notification settings - Fork 31.4k
util: update util.isArray() to eol #58027
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
Co-authored-by: Edy Silva <[email protected]>
It seems like there is still some hesitation about doing this - #58013 (comment). |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #58027 +/- ##
==========================================
- Coverage 90.28% 90.27% -0.02%
==========================================
Files 630 630
Lines 186158 186325 +167
Branches 36484 36498 +14
==========================================
+ Hits 168067 168198 +131
- Misses 10974 11005 +31
- Partials 7117 7122 +5
🚀 New features to boost your workflow:
|
I think build is failing because a link to the |
Co-authored-by: Edy Silva <[email protected]>
Failed to start CI⚠ Commits were pushed since the last approving review: ⚠ - util: update util.isArray() to eol ⚠ - Update version change with pr number ⚠ - fix endoflife typo ⚠ - Fix typo from version ⚠ - doc: update deprecation notice for util.isArray() removal ⚠ - doc: remove unused reference to Array.isArray() in util documentation ✘ Refusing to run CI on potentially unsafe PRhttps://github.com/nodejs/node/actions/runs/14686825918 |
Refs #58013
Update
util.isArray
to eol