Skip to content

util: update util.isArray() to eol #58027

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 6 commits into
base: main
Choose a base branch
from

Conversation

miguelmarcondesf
Copy link

Refs #58013

Update util.isArray to eol

@nodejs-github-bot nodejs-github-bot added needs-ci PRs that need a full CI run. util Issues and PRs related to the built-in util module. labels Apr 25, 2025
@geeksilva97 geeksilva97 requested review from jasnell and cjihrig April 25, 2025 19:25
@cjihrig
Copy link
Contributor

cjihrig commented Apr 25, 2025

It seems like there is still some hesitation about doing this - #58013 (comment).

@ljharb ljharb added the needs-citgm PRs that need a CITGM CI run. label Apr 25, 2025
Copy link

codecov bot commented Apr 25, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 90.27%. Comparing base (9cc0195) to head (d29f97e).
Report is 20 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main   #58027      +/-   ##
==========================================
- Coverage   90.28%   90.27%   -0.02%     
==========================================
  Files         630      630              
  Lines      186158   186325     +167     
  Branches    36484    36498      +14     
==========================================
+ Hits       168067   168198     +131     
- Misses      10974    11005      +31     
- Partials     7117     7122       +5     
Files with missing lines Coverage Δ
lib/util.js 97.74% <ø> (-0.02%) ⬇️

... and 31 files with indirect coverage changes

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@anonrig anonrig added the semver-major PRs that contain breaking changes and should be released in the next major version. label Apr 25, 2025
@geeksilva97
Copy link
Contributor

I think build is failing because a link to the util.isArray still exists at https://github.com/nodejs/node/blob/main/doc/api/deprecations.md?plain=1#L998 and https://github.com/nodejs/node/blob/main/doc/api/deprecations.md?plain=1#L4031.

@geeksilva97 geeksilva97 added the request-ci Add this label to start a Jenkins CI on a PR. label Apr 27, 2025
@github-actions github-actions bot added request-ci-failed An error occurred while starting CI via request-ci label, and manual interventon is needed. and removed request-ci Add this label to start a Jenkins CI on a PR. labels Apr 27, 2025
Copy link
Contributor

Failed to start CI
   ⚠  Commits were pushed since the last approving review:
   ⚠  - util: update util.isArray() to eol
   ⚠  - Update version change with pr number
   ⚠  - fix endoflife typo
   ⚠  - Fix typo from version
   ⚠  - doc: update deprecation notice for util.isArray() removal
   ⚠  - doc: remove unused reference to Array.isArray() in util documentation
   ✘  Refusing to run CI on potentially unsafe PR
https://github.com/nodejs/node/actions/runs/14686825918

@geeksilva97 geeksilva97 added request-ci Add this label to start a Jenkins CI on a PR. and removed request-ci-failed An error occurred while starting CI via request-ci label, and manual interventon is needed. labels Apr 28, 2025
@github-actions github-actions bot removed the request-ci Add this label to start a Jenkins CI on a PR. label Apr 28, 2025
@nodejs-github-bot
Copy link
Collaborator

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
needs-ci PRs that need a full CI run. needs-citgm PRs that need a CITGM CI run. semver-major PRs that contain breaking changes and should be released in the next major version. util Issues and PRs related to the built-in util module.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants