Skip to content

buffer: use Utf8LengthV2() instead of Utf8Length() #58156

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

buffer: use Utf8LengthV2() instead of Utf8Length() #58156

wants to merge 1 commit into from
+1 −1

Conversation

tniessen
Copy link
Member

@tniessen tniessen commented May 4, 2025

Utf8Length() is deprecated and was replaced during the V8 update (0e68481), but 084a912 introduced a new occurrence.

Refs: #58070
Refs: #58048

@tniessen
buffer: use Utf8LengthV2() instead of Utf8Length()
caf58f2 
`Utf8Length()` is deprecated and was replaced during the V8 update, but
a subsequent commit introduced a new occurrence.

Refs: nodejs#58070
Refs: nodejs#58048
@tniessen tniessen added c++ Issues and PRs that require attention from people who are familiar with C++. v8 engine Issues and PRs related to the V8 dependency. labels May 4, 2025
@nodejs-github-bot nodejs-github-bot added buffer Issues and PRs related to the buffer subsystem. needs-ci PRs that need a full CI run. labels May 4, 2025
@codecov Codecov
Copy link

codecov bot commented May 4, 2025 •
edited
Loading

Codecov Report

Attention: Patch coverage is 0% with 1 line in your changes missing coverage. Please review.

Project coverage is 90.17%. Comparing base (92102c0) to head (caf58f2).
Report is 15 commits behind head on main.

Files with missing lines Patch % Lines
src/node_buffer.cc 0.00% 1 Missing ⚠️
Additional details and impacted files 
@@            Coverage Diff             @@
##             main   #58156      +/-   ##
==========================================
- Coverage   90.18%   90.17%   -0.01%     
==========================================
  Files         630      630              
  Lines      186473   186503      +30     
  Branches    36612    36613       +1     
==========================================
+ Hits       168169   168187      +18     
- Misses      11116    11121       +5     
- Partials     7188     7195       +7
Files with missing lines Coverage Δ
src/node_buffer.cc 68.99% <0.00%> (-0.11%) ⬇️

... and 29 files with indirect coverage changes

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@Flarna Flarna added the request-ci Add this label to start a Jenkins CI on a PR. label May 4, 2025
@github-actions github-actions bot removed the request-ci Add this label to start a Jenkins CI on a PR. label May 4, 2025
@nodejs-github-bot

This comment was marked as outdated.

Sign in to view
@nodejs-github-bot
Copy link
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/66594/

@nodejs-github-bot
Copy link
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/66601/

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@anonrig anonrig anonrig approved these changes

@cjihrig cjihrig cjihrig approved these changes

@Flarna Flarna Flarna approved these changes

Assignees
No one assigned
Labels
buffer Issues and PRs related to the buffer subsystem. c++ Issues and PRs that require attention from people who are familiar with C++. needs-ci PRs that need a full CI run. v8 engine Issues and PRs related to the V8 dependency.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@tniessen @nodejs-github-bot @anonrig @cjihrig @Flarna