Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

repl: Tab complete when useGlobal is false #7354

Closed
wants to merge 1 commit into from
Closed

repl: Tab complete when useGlobal is false #7354

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 9 additions & 1 deletion lib/repl.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -585,7 +585,15 @@ REPLServer.prototype.createContext = function() {
context = global;
} else {
context = vm.createContext();
for (var i in global) context[i] = global[i];
// #7353 - tab complete returns fewer results
context.global = global;
vm.runInContext(`
(function() {
for (let name of Object.getOwnPropertyNames(global)) {
this[name] = this[name];
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is this used to make the properties of global enumerable? If so, that’s probably an unwanted side effect here (if not… could you explain what this does?).

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@addaleax I got it! its not a proper fix.

}
})()
`, context);
context.console = new Console(this.outputStream);
context.global = context;
context.global.global = context;
Expand Down
11 changes: 11 additions & 0 deletions test/parallel/test-repl-tab-complete.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -260,3 +260,14 @@ putIn.run(['.clear']);
testMe.complete('var log = console.lo', common.mustCall((error, data) => {
assert.deepStrictEqual(data, [['console.log'], 'console.lo']);
}));

var testNonGlobal = repl.start({
input: putIn,
output: putIn,
useGlobal: false
});

testNonGlobal.complete('I', common.mustCall((error, data) => {
assert.deepStrictEqual(data, [['Infinity', '', 'Int16Array', 'Int32Array',
'Int8Array', 'Intl'], 'I']);
}));