Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test: fix flaky test-tls-wrap-timeout #7926

Closed
wants to merge 1 commit into from
Closed

Conversation

Trott
Copy link
Member

@Trott Trott commented Jul 31, 2016

  • make -j4 test (UNIX), or vcbuild test nosign (Windows) passes
  • commit message follows commit guidelines
Affected core subsystem(s)

test tls

Description of change

Alternative to #7857

@Trott Trott added tls Issues and PRs related to the tls subsystem. test Issues and PRs related to the tests. labels Jul 31, 2016
@Trott
Copy link
Member Author

Trott commented Jul 31, 2016

Version of this test modified to work in io.js 1.x that I used to confirm this still fails in 1.2 (where the original bug was present) and passes in 1.3 (where it is fixed):

https://gist.github.com/Trott/0ebc6b18a8f5b8bcea5f8eb253a11180

@Trott
Copy link
Member Author

Trott commented Jul 31, 2016

Stress test on master (should show failures):
https://ci.nodejs.org/job/node-stress-single-test/841/nodes=freebsd10-64/console

Stress test using this version (should not fail):
https://ci.nodejs.org/job/node-stress-single-test/842/nodes=freebsd10-64/console

@Trott
Copy link
Member Author

Trott commented Jul 31, 2016

(Because we only have 2 FreeBSD hosts in CI, and I was tying them both up by running the simultaneous stress tests, I canceled the stress test on master because after 3180 runs, it had 27 failures, thus demonstrating the test is flaky. It didn't seem necessary to let it run all the way to 9999.)

(Still running the stress test against this PR, which has 0 failures after over 3300 runs.)

@Trott
Copy link
Member Author

Trott commented Jul 31, 2016

Ci is green: https://ci.nodejs.org/job/node-test-commit/4336/

Stress test is green after ~5000 runs, another ~5000 to go.

/cc @indutny @nodejs/testing @santigimeno @jasnell

@Trott
Copy link
Member Author

Trott commented Jul 31, 2016

Closed in favor of #7857

@Trott Trott closed this Jul 31, 2016
@Trott Trott deleted the wrap2 branch January 13, 2022 22:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
test Issues and PRs related to the tests. tls Issues and PRs related to the tls subsystem.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant