Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Error in guide to dockerizing nodejs #1344

Closed
rm-rf-etc opened this issue Aug 24, 2017 · 3 comments
Closed

Error in guide to dockerizing nodejs #1344

rm-rf-etc opened this issue Aug 24, 2017 · 3 comments
Labels
good first issue Issues for newcomers

Comments

@rm-rf-etc
Copy link
Contributor

The following instruction, given by the above tutorial, causes a build to fail.
COPY package.json package-lock.json .

The error message reads:

Step 3/7 : COPY ./package.json ./package-lock.json .
When using COPY with more than one source file, the destination must be a directory and end with a /
@pierreneter
Copy link
Contributor

I think it should be COPY package.json package-lock.json ./. can you submit a PR to fix this tutorial?

@pierreneter pierreneter added docs good first issue Issues for newcomers labels Aug 24, 2017
@rm-rf-etc
Copy link
Contributor Author

Created pull/1346. Sorry if I missed any aspects of standard protocol.

pierreneter pushed a commit that referenced this issue Aug 24, 2017
@rm-rf-etc @pierreneter
Fix instruction in dockerization guide. Issue #1344 (#1346)
37135a8
@pierreneter
Copy link
Contributor

Thanks!

hackygolucky added a commit to hackygolucky/nodejs.org that referenced this issue Sep 19, 2017
@hackygolucky
Merge branch 'master' of https://github.com/nodejs/nodejs.org
71683d9 
* 'master' of https://github.com/nodejs/nodejs.org: (22 commits)
  Add Myles as TSC Director (nodejs#1365)
  board: add Myles Borins (nodejs#1362)
  doc: fix some links in guides (nodejs#1363)
  blog: update 8.5.0 release
  blog: v8.5.0 release post (nodejs#1360)
  Update board.md (nodejs#1359)
  Merge Website WG Members and Collaborators 🎉 (nodejs#1357)
  Updated it translation for index.md (nodejs#1353)
  Get data from google doc for Announcements (nodejs#1332)
  fix silver section head and paypal location (nodejs#1355)
  layouts/in-the-news.hbs: Use JS standard style (nodejs#1352)
  blog: release post for v6.11.3
  Change member class (nodejs#1350)
  Fix wrongs Language Names in Working Groups page. (nodejs#1347)
  Remove current gold director (nodejs#1348)
  Fix instruction in dockerization guide. Issue nodejs#1344 (nodejs#1346)
  Update TSC member list (nodejs#1343)
  Update site.json of zh-cn locale (nodejs#1339)
  Update Silver member Directors for August 2017 (nodejs#1341)
  blog: add release post for v8.4.0 (nodejs#1340)
  ...
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
good first issue Issues for newcomers
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@rm-rf-etc @pierreneter