Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

zh-TW:Add missing translation for 'Collab Summit' #1826

Merged
2 commits merged into from Sep 29, 2018
Merged

zh-TW:Add missing translation for 'Collab Summit' #1826

2 commits merged into from Sep 29, 2018

Conversation

ghost
Copy link

@ghost ghost commented Sep 29, 2018

Add this missing Traditional Chinese for 'Collab Summit'.

Add this missing Traditional Chinese for 'Collab Summit'.
@ghost ghost requested review from dca and osk2 September 29, 2018 08:18
Copy link
Contributor

@osk2 osk2 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm thinking that if it's necessary to translate "Collab Summit". if so, then we'll need to translate words in collab-summit.md too.

@ghost
Copy link
Author

ghost commented Sep 29, 2018

collab-summit.md has been translated into zh-TW as:https://nodejs.org/zh-tw/get-involved/collab-summit/.

You see that we've translated once about "Collab Submmit" as "協作者峰會". And for the rest, there's no need to translate because they are fixed special pharses.

@osk2
Copy link
Contributor

osk2 commented Sep 29, 2018

I mean the word "Collab Summit" :P

I left them untranslated in collab-summit.md. If we decide to translate them to "協作者峰會", we should also replace "Collab Summit" with "協作者峰會" in collab-summit.md.

Copy link
Contributor

@osk2 osk2 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice, looks much better now 👍

@ghost ghost merged commit 2b06a0b into nodejs:master Sep 29, 2018
This pull request was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant