-
Notifications
You must be signed in to change notification settings - Fork 6.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: node.js -> Node.js #2657
fix: node.js -> Node.js #2657
Conversation
Manually reviewed since casing is intended for emails and some urls.
@nodejs/website |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks!
locale/en/knowledge/getting-started/control-flow/how-to-write-asynchronous-code.md
Outdated
Show resolved
Hide resolved
locale/en/knowledge/getting-started/how-to-debug-nodejs-applications.md
Outdated
Show resolved
Hide resolved
locale/en/knowledge/getting-started/control-flow/how-to-write-asynchronous-code.md
Outdated
Show resolved
Hide resolved
locale/en/knowledge/getting-started/control-flow/what-are-callbacks.md
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Some changes needed per comments. (Not sure about all of them, but some of them are definitely required.) Feel free to dismiss this "request changes" review once changes have been applied.
Co-Authored-By: Aissaoui Ahmed <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
BTW I wouldn't remove the double spaces after a period in this PR. It seems it is in many places; I believe some people prefer writing like that. Personally I don't agree with that, but still, it should be done in a separate PR and tackle all of the instances. |
Manually reviewed since casing is intended for emails and some urls.