copyedit profiling guide #446
Conversation
|
LGTM. |
|
Maybe leave a reference of where this is copied from? |
| can be processed using this tool by running: | ||
| form `isolate-0xnnnnnnnnnnnn-v8.log` (where `n` is a digit). In order to make | ||
| sense of this file, we need to use the tick processor included in the Node.js | ||
| source at `<nodejs_dir>/tools/v8-prof /tick-processor.js`. It is important that |
There was a problem hiding this comment.
Superfluous space in command
|
@stevemao It's the exact same text as before (with adjusted wrapping) and new " |
|
Oh from the commit message I thought it was copied from somewhere. |
|
@stevemao I was using copyedit in this context: https://en.wikipedia.org/wiki/Copy_editing I use that word a lot in my commit messages (when I'm fixing typos, punctuation, formatting, etc.) but if it's confusing to a lot of people, I can try to use a synonym instead. |
|
@Trott It's Ok I guess. My English is very bad 😄 |
| form `isolate-0xnnnnnnnnnnnn-v8.log` (where `n` is a digit). In order to make | ||
| sense of this file, we need to use the tick processor included in the Node.js | ||
| source at `<nodejs_dir>/tools/v8-prof /tick-processor.js`. It is important that | ||
| the version of the tick-processor comes from the source for the version of node |
There was a problem hiding this comment.
Hm, should we also mention the --prof-process flag now?
|
Merged via 6a61f69, thanks! |
No description provided.