learn: Update Don't Block the Event Loop outdated remark about fs.readFile()
#7493
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Thiago Romano <[email protected]>
Signed-off-by: Thiago Romano <[email protected]>
Signed-off-by: Thiago Romano <[email protected]>
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
AugustinMauroy
approved these changes
Feb 23, 2025
AugustinMauroy
added
content
aymen94
approved these changes
Mar 11, 2025
avivkeller
changed the title
fs.readFile()fs.readFile()
github-actions
bot
removed
the
github_actions:pull-request
|
Lighthouse Results
|
Unit Test Coverage Report
Unit Test Report
|
|
Thanks for your contribution, @thiagopromano! It'll be merged shortly! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
The Don't Block the Event Loop article mentions the
fs.readFile()is "currently" not partitioned. This is not the case anymore since v10.We could either leave the example mentioning that this was the behavior up to v10, as currently implemented in this PR, change it to use
fs.read(), or remove this example altogether.