Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Restore browser tests #339

Closed
vweevers opened this issue Jun 3, 2018 · 7 comments
Closed

Restore browser tests #339

vweevers opened this issue Jun 3, 2018 · 7 comments

Comments

@vweevers
Copy link
Contributor

vweevers commented Jun 3, 2018

Over at Airtap (airtap/airtap#171) we have been wondering which browsers readable-stream will target, if and when browser tests are restored. Specifically whether IE9 and IE10 support is still required?

I can do a PR to setup airtap, unless you want to wait for a stable release (airtap/airtap#170).

@mcollina /cc @feross @ralphtheninja

@mcollina
Copy link
Member

mcollina commented Jun 3, 2018

I have been working on readable-stream@3 at https://github.com/nodejs/readable-stream/commits/next. I do not have all tests passing yet.

It would be fantastic to have airtap supported there, and I think won't need IE9 and IE10 support there anyway.

Would you like to send a PR against that? The 2.x line should support IE9 and IE10, even thought we are not really testing them at this point.

@vweevers
Copy link
Contributor Author

vweevers commented Jun 3, 2018

Would you like to send a PR against that?

Sure! I noticed you removed the matrix from .travis.yml (e9cde33). Do you want me to wait until the tests are passing in node?

@mcollina
Copy link
Member

mcollina commented Jun 3, 2018

@vweevers feel free to re-add the matrix for the browser things. We will not be supporting ancient Node anymore.

@vweevers
Copy link
Contributor Author

vweevers commented Jun 3, 2018

Opera 11 (fd1efbf) is also pretty old, and the version range 11..latest is huge. Perhaps the target should be -3..latest like the other evergreen browsers?

@vweevers
Copy link
Contributor Author

vweevers commented Jun 3, 2018

It would be fantastic to have airtap supported there, and I think won't need IE9 and IE10 support there anyway.

cc @jhiesey because you said you want IE9/10 in stream-http which depends on readable-stream.

@mcollina
Copy link
Member

mcollina commented Jun 3, 2018

@vweevers +1 of having the same range.

@vweevers
Copy link
Contributor Author

vweevers commented Jun 3, 2018

#340

mcollina added a commit that referenced this issue Aug 10, 2018
Fixes #283
Fixes #284
Fixes #212
Fixes #297
Fixes #346
Fixes #339
Fixed #335
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants