fix: use workaround loading process-shim for browserify #497
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Also happened on #491. Safe to ignore: #491 (comment). Although it might be preferable to open a separate PR that only does a rebuild; then these two PRs will be cleaner. |
|
@mcollina I've updated the PR. The diff is now much smaller and more readable. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
replaced
require('process')withrequire('process/')to fix #496The build step generated quite a big diff. I compared a few samples with the code in the https://github.com/nodejs/node repository, and the generated code looks good to me. I think there was a problem earlier on.
@mcollina Hints on how to solve this are very welcome. Is there a post-process step? Should I create a separate PR just for the diff generated by the build and then fix the process-shim issue?