fetch: multiple small fixes #1166
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## main #1166 +/- ##
==========================================
+ Coverage 93.76% 93.79% +0.02%
==========================================
Files 40 40
Lines 3817 3818 +1
==========================================
+ Hits 3579 3581 +2
+ Misses 238 237 -1
Continue to review full report at Codecov.
|
KhafraDev
added a commit
to KhafraDev/undici
that referenced
this pull request
Jun 23, 2022
* fix: 'same origin' & setting response * fix: remove httpRedirectFetch step #12
metcoder95
pushed a commit
to metcoder95/undici
that referenced
this pull request
Dec 26, 2022
* fix: 'same origin' & setting response * fix: remove httpRedirectFetch step #12
crysmags
pushed a commit
to crysmags/undici
that referenced
this pull request
Feb 27, 2024
* fix: 'same origin' & setting response * fix: remove httpRedirectFetch step nodejs#12
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR contains 3 fetch bug fixes:
mainFetch,responsewas not being set in 2 places ("then set response to a network error.").httpRedirectFetch, the old step 12 has been removed