Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

use URLSearchParams instead of querystring #1682

Closed
wants to merge 1 commit into from
Closed

use URLSearchParams instead of querystring #1682

wants to merge 1 commit into from

Conversation

Kikobeats
Copy link
Contributor

@Kikobeats Kikobeats commented Oct 4, 2022 •
edited
Loading

querystring is legacy API

@Kikobeats Kikobeats changed the title use urlsearchparams instead of querystring use URLSearchParams instead of querystring Oct 4, 2022
@Kikobeats Kikobeats mentioned this pull request Oct 4, 2022
Closed
@ronag
Copy link
Member

ronag commented Oct 4, 2022

I don't see any advantage of this? It will just be slower...

@anonrig
Copy link
Member

anonrig commented Oct 4, 2022

You can find a benchmark that compares alternatives from https://github.com/anonrig/fast-querystring#benchmark

@mcollina mcollina closed this Oct 6, 2022
@Kikobeats Kikobeats deleted the querystring branch October 6, 2022 13:56
@mcollina mcollina mentioned this pull request Oct 7, 2022
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@Kikobeats @ronag @anonrig @mcollina