Fix handling of UVWASI_LOOKUP_SYMLINK_FOLLOW in uvwasi_path_filestat_get #133
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
If uvwasi_path_filestat_get the pathname is resolved by uvwasi__resolve_path which honors the UVWASI_LOOKUP_SYMLINK_FOLLOW flag. Later we were we unconditionally calling uv_fs_stat which always follows symlinks. Instead we want to unconditionally call uv_fs_lstat which never follows them (since the resolution was already handled by the preceding call to uvwasi__resolve_path).
cjihrig
added a commit
that referenced
this pull request
Aug 2, 2020
Notable changes: - The uvwasi_preopen_t now uses const char* for the mapped_path and real_path fields. Previously, these were not const. (#130) - uvwasi_path_filestat_get() now properly handles the UVWASI_LOOKUP_SYMLINK_FOLLOW flag. (#133) - uvwasi_options_init() has been added to reduce the boilerplate code associated with initializing uvwasi_options_t's. (#141) - The DEBUG() macro has been renamed to UVWASI_DEBUG() to reduce naming conflicts with other projects. (#143) - A compilation error on NetBSD 8.2 has been fixed. (#146) - The uvwasi_fd_filestat_set_times() and uvwasi_path_filestat_set_times() functions now have proper implementations. (#139)
Merged
cjihrig
added a commit
that referenced
this pull request
Aug 4, 2020
Notable changes: - The uvwasi_preopen_t now uses const char* for the mapped_path and real_path fields. Previously, these were not const. (#130) - uvwasi_path_filestat_get() now properly handles the UVWASI_LOOKUP_SYMLINK_FOLLOW flag. (#133) - uvwasi_options_init() has been added to reduce the boilerplate code associated with initializing uvwasi_options_t's. (#141) - The DEBUG() macro has been renamed to UVWASI_DEBUG() to reduce naming conflicts with other projects. (#143) - A compilation error on NetBSD 8.2 has been fixed. (#146) - The uvwasi_fd_filestat_set_times() and uvwasi_path_filestat_set_times() functions now have proper implementations. (#139)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If uvwasi_path_filestat_get the pathname is resolved by
uvwasi__resolve_path which honors the UVWASI_LOOKUP_SYMLINK_FOLLOW
flag.
Later we were we unconditionally calling uv_fs_stat which always
follows symlinks. Instead we want to unconditionally call uv_fs_lstat
which never follows them (since the resolution was already handled
by the preceding call to uvwasi__resolve_path).