Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: bump to es2022 support #10

Merged
merged 1 commit into from
Nov 8, 2021
Merged

fix: bump to es2022 support #10

merged 1 commit into from
Nov 8, 2021

Conversation

wraithgar
Copy link
Member

@wraithgar wraithgar commented Nov 4, 2021

BREAKING CHANGE: this drops support for eslint@7
Our testing matrix is where we ensure we are working in the environments
we need. The linter is not what should be slowing us down with what
features we write.

@wraithgar wraithgar requested a review from a team as a code owner November 4, 2021 22:08

Verified

This commit was signed with the committer’s verified signature. The key has expired.
BREAKING CHANGE: this drops support for eslint@7
Our testing matrix is where we ensure we are working in the environments
we need. The linter is not what should be slowing us down with what
features we write.
@lukekarrys
Copy link
Contributor

Not a blocker but I wanted to point out that node/process-exit-as-throw is currently broken with eslint@8: mysticatea/eslint-plugin-node#301

I think we should manually disable any cases that break because of this with a comment to revisit when that issue is fixed.

@wraithgar
Copy link
Member Author

Well hopefully process.exit() isn't in any of our hot paths outside of things like the helper bins that ship with things like pacote or arborist. Seems like a good place to double check that the code looks right anyways, and the cli itself is the only process.exit() that we really need to be super prescriptive about.

@wraithgar wraithgar merged commit 41ec96d into main Nov 8, 2021
@wraithgar wraithgar deleted the gar/es2022 branch November 8, 2021 14:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants