Skip to content
This repository was archived by the owner on Feb 15, 2022. It is now read-only.

User murmur instead of md5 #6

Closed
wants to merge 2 commits into from
Closed

User murmur instead of md5 #6

wants to merge 2 commits into from

Conversation

stefanmb
Copy link
Contributor

MD5 is disallowed in FIPS mode, use a pure JS version of murmur instead.

Resolves #5

Without the file it defaults to Ruby
MD5 is disallowed in FIPS mode, use a pure JS
version of murmur instead.
@stefanmb
Copy link
Contributor Author

@othiym23 Any feedback on this? Thanks in advance!

@othiym23
Copy link
Contributor

othiym23 commented Dec 1, 2015

I'm working on landing this, but also making sure that the tests work properly in Node.js 0.8 at the same time. I also took the opportunity to bring this package under npm's umbrella of using standard for CLI-related packages, and so I made a few tweaks to your patch to match standard style, but the changes themselves look good. I'll get this landed later today.

@othiym23
Copy link
Contributor

othiym23 commented Dec 2, 2015

OK! I rebased and landed this as dfaac1b, which is included in [email protected], which will be included in the next versions of npm@2 and npm@3. Thanks for your patience, and thanks for putting this together!

@othiym23 othiym23 closed this Dec 2, 2015
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants