Skip to content

feat: require this packaged to be a pinned dep #94

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Mar 17, 2022
Merged

feat: require this packaged to be a pinned dep #94

merged 2 commits into from
Mar 17, 2022

Conversation

lukekarrys
Copy link
Contributor

Fixes: #88
Fixes: #93

@lukekarrys lukekarrys requested a review from a team as a code owner March 17, 2022 06:27
@wraithgar
Copy link
Member

Looks like this may have overlap w/ another PR? #92

@lukekarrys
Copy link
Contributor Author

Looks like this may have overlap w/ another PR? #92

It shouldn't be. I just merged that, and this doesn't have any conflicts. I did push an unrelated refactor commit (8038395) which is probably why the diff looks weird.

@lukekarrys lukekarrys merged commit c07a300 into main Mar 17, 2022
@lukekarrys lukekarrys deleted the lk/require-pinned branch March 17, 2022 15:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@wraithgar wraithgar wraithgar approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Should check that itself is a pinned dep Remove tap version requirements
2 participants
@lukekarrys @wraithgar